Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make NodeState generic over DB with DatabaseMetadata #5691

Merged
merged 7 commits into from
Dec 18, 2023
Merged

feat: make NodeState generic over DB with DatabaseMetadata #5691

merged 7 commits into from
Dec 18, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Dec 5, 2023

Depends on #5690

This introduces another trait DatabaseMetadata, allowing the NodeState to be generic over DB instead of using DatabaseEnv.

@Rjected Rjected added C-enhancement New feature or request S-blocked This cannot more forward until something else changes A-db Related to the database A-cli Related to the reth CLI labels Dec 5, 2023
@Rjected Rjected force-pushed the dan/generic-db-node-state branch 2 times, most recently from 15efe33 to 8a532f9 Compare December 5, 2023 03:13
mattsse
mattsse requested changes Dec 6, 2023
View reviewed changes
bin/reth/src/node/events.rs Outdated Show resolved Hide resolved
bin/reth/src/node/events.rs Outdated Show resolved Hide resolved
crates/storage/db/src/abstraction/database_metrics.rs Outdated Show resolved Hide resolved
crates/storage/db/src/abstraction/database_metrics.rs Outdated Show resolved Hide resolved
@Rjected Rjected force-pushed the dan/generic-db-node-state branch 3 times, most recently from a6d93c7 to 6dec6a8 Compare December 11, 2023 22:44
@Rjected Rjected removed the S-blocked This cannot more forward until something else changes label Dec 14, 2023
@Rjected Rjected mentioned this pull request Dec 15, 2023
Merged
@Rjected Rjected requested a review from mattsse December 18, 2023 08:02
mattsse
mattsse approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse marked this pull request as ready for review December 18, 2023 08:25
@mattsse mattsse added this pull request to the merge queue Dec 18, 2023
Merged via the queue into main with commit 900fe7e Dec 18, 2023
27 checks passed
@mattsse mattsse deleted the dan/generic-db-node-state branch December 18, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-db Related to the database C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse