Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(net): Improved Masking Function for Message IDs #5724

Merged
merged 2 commits into from
Dec 11, 2023
Merged

refactor(net): Improved Masking Function for Message IDs #5724

merged 2 commits into from
Dec 11, 2023

Conversation

tcoratger
Copy link
Contributor

@tcoratger tcoratger commented Dec 10, 2023 •
edited
Loading

Description

The function mask_msg_id of the MuxDemuxStream structure has been updated for improved efficiency and clarity.

mattsse
mattsse requested changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this saves an extend_with(len, 0) call

though this should still call extend_from_slice and not put because put extends in chunks and has additional checks that we don't need here

@tcoratger
Copy link
Contributor Author

@mattsse Tell me if you think it's better now :)

mattsse
mattsse approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Dec 11, 2023
Merged via the queue into paradigmxyz:main with commit ae8ad6f Dec 11, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoratger @mattsse