Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve CLI reference generator #5740

Merged
merged 5 commits into from
Dec 14, 2023
Merged

docs: improve CLI reference generator #5740

merged 5 commits into from
Dec 14, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Dec 12, 2023

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool,

pending @shekhirin

@@ -426,7 +425,7 @@ Logging:
--log.file.directory <PATH>
The path to put log files in

[default: /reth/logs]
[default: /home/doni/.config/cache/reth/logs]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want it to be a user- and platform-agnostic path

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shekhirin shekhirin added C-docs An addition or correction to our documentation A-meta Changes in the contributor workflow and planning labels Dec 14, 2023
@shekhirin shekhirin added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit 744930f Dec 14, 2023
27 checks passed
@shekhirin shekhirin deleted the dani/better-helpgen branch December 14, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Changes in the contributor workflow and planning C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants