Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor improve for compression dir #5755

Merged
merged 2 commits into from
Dec 15, 2023
Merged

minor improve for compression dir #5755

merged 2 commits into from
Dec 15, 2023

Conversation

yjhmelody
Copy link
Contributor

Better to make the static config be non rust file

DaniPopes
DaniPopes requested changes Dec 14, 2023
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK, but we can go further and make the files binary and us e include_bytes! if you don't mind implementing this

@yjhmelody
Copy link
Contributor Author

yjhmelody commented Dec 14, 2023 •
edited
Loading

i think now it is better ， the file is also legal json array（maybe need to handle tail comma）

@DaniPopes DaniPopes added this pull request to the merge queue Dec 15, 2023
Merged via the queue into paradigmxyz:main with commit 764c7ae Dec 15, 2023
27 checks passed
@DaniPopes DaniPopes mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yjhmelody @DaniPopes