Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reduce static data size #5770

Merged
merged 2 commits into from
Dec 15, 2023
Merged

perf: reduce static data size #5770

merged 2 commits into from
Dec 15, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Dec 15, 2023

#5755 (review)

800KiB to 200KiB of compression dictionaries static data

Using

def do_the_thing(p):
    with open(p, "r") as f:
        s = f.read()
    arr=eval(s)
    arr=bytearray(arr)
    with open(p, "wb") as f:
        f.write(arr)

do_the_thing("./receipt_dictionary.in")
do_the_thing("./transaction_dictionary.in")

@DaniPopes DaniPopes changed the title feat: make Reth binary smaller perf: make Reth binary smaller Dec 15, 2023
@DaniPopes DaniPopes changed the title perf: make Reth binary smaller perf: reduce static data size Dec 15, 2023
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm provided this runs on an existing db

@onbjerg onbjerg added the C-perf A change motivated by improving speed, memory usage or disk footprint label Dec 15, 2023
@DaniPopes DaniPopes added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit ff18375 Dec 15, 2023
27 checks passed
@DaniPopes DaniPopes deleted the dani/smaller-compression branch December 15, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants