feat: preload cachedreads with tip state #5804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CachedReads preload
… noop function on_new_state
mattsse
requested changes
Dec 18, 2023
rkrasiuk
added
C-perf
…und Events with Unpin
mattsse
requested changes
Dec 20, 2023
…y to resolve compiler errors
mattsse
requested changes
Dec 29, 2023
|
sorry about the conflicts -.- |
mattsse
force-pushed
the
feat/preload-cached-reads
branch
from
5f7c206
to
2adb0c8
Compare
mattsse
changed the title
mattsse
reviewed
Jan 9, 2024
crates/payload/basic/src/lib.rs
Outdated
Comment on lines
207
to
226
| fn on_new_state(&mut self, new_state: CanonStateNotification) { | ||
| if let Some(committed) = new_state.committed() { | ||
| let mut cached = CachedReads::default(); | ||
|
|
||
| // extract the state from the notification and put it into the cache | ||
| let new_state = committed.state(); | ||
| for (addr, acc) in new_state.accounts_iter() { | ||
| if let Some(acc) = acc { | ||
| let storage = if let Some(acc) = new_state.state().account(&addr) { | ||
| acc.storage.iter().map(|(key, slot)| (*key, slot.present_value)).collect() | ||
| } else { | ||
| Default::default() | ||
| }; | ||
| cached.insert_account(addr, acc.clone(), storage); | ||
| } | ||
| } | ||
|
|
||
| self.pre_cached = Some(PrecachedState { block: committed.tip().hash, cached }); | ||
| } | ||
| } |
There was a problem hiding this comment.
In general this is okay, but would add helper function to BundleStateWithReceipts to make it more obvious, maybe something like fn bundle_account_iter().
To point out, the bundle state contains only written accounts, not the reads, but it is still better than nothing.
rkrasiuk
approved these changes
Jan 9, 2024
mattsse
force-pushed
the
feat/preload-cached-reads
branch
from
d99e662
to
7d6eeea
Compare
mattsse
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft PR for cache reads preload