-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: preload cachedreads with tip state #5804
Merged
Merged
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8513037
feat: explore payload builder, prepare boilerplate code for the next …
allnil caf046c
feat: pass canon state notification stream to payload loader, add new…
allnil 558313a
save progress
allnil 36befd2
remove generic stream type for chain events
allnil f260505
Merge branch 'main' of github.com:allnil/reth into feat/preload-cache…
allnil 59fbc48
pass reth components events stream in payload builder service, add bo…
allnil 6b5bfd2
refactor traits, add task to grab events and new tip
allnil f8705c9
Merge branch 'main' of github.com:allnil/reth into feat/preload-cache…
allnil 1b8f281
Merge branch 'main' of github.com:allnil/reth into feat/preload-cache…
allnil 5ea77b3
chore: refactor code, get canonical_chain_stream, remove generics, tr…
allnil 264f825
chore: get back unpin from canon state notifications in components
allnil 706e992
chore: remove clone trait from payload generator in future
allnil e1a31f2
chore: successfully pass stream to the payload service, clean rubbish
allnil 42c7059
chore: experiment with cache_reads preservation
allnil eb6a55e
merge
allnil 86ad016
merge
allnil 65bebed
changed on_new_state signature to &mut self
allnil f5d1ceb
Merge branch 'main' into feat/preload-cached-reads
mattsse 2adb0c8
feat: preload cache based on committed state
mattsse 0f3d4ae
fix: make tests compile
mattsse c42025b
move to helper fn
mattsse e86b1c3
Merge branch 'main' into feat/preload-cached-reads
mattsse 7d6eeea
update interface
mattsse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rakita @rkrasiuk could you please take a closer look here.
It's not really obvious to me how I can get the plain state (account, accountstorage) from the Bundlestate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this is okay, but would add helper function to
BundleStateWithReceipts
to make it more obvious, maybe something likefn bundle_account_iter()
.To point out, the bundle state contains only written accounts, not the reads, but it is still better than nothing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattsse you can create a new method
accounts_with_storage_iter
to make it easier. @rakita made good point that these are only writes, but that's better than nothing