Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(consensus): correct the fork name for validating 1559 transaction #5849

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix(consensus): correct the fork name for validating 1559 transaction #5849

merged 1 commit into from
Dec 22, 2023

Conversation

hsyodyssey
Copy link
Contributor

  • Considering the context, this part would be Hardfork::London?
  • It works well for sure(no errors), as it readlly didn't enbale EIP-1559 at the Berlin hardfork.

mattsse
mattsse approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, this should be london indeed, ty!

pending @Rjected

@mattsse mattsse requested a review from Rjected December 22, 2023 16:02
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-consensus Related to the consensus engine labels Dec 22, 2023
Rjected
Rjected approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks!

@Rjected Rjected added this pull request to the merge queue Dec 22, 2023
@Rjected Rjected mentioned this pull request Dec 22, 2023
Merged
Merged via the queue into paradigmxyz:main with commit 8fb6ed9 Dec 22, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsyodyssey @Rjected @mattsse