Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve rlp transaction encoding docs #5922

Merged
merged 6 commits into from
Jan 2, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jan 2, 2024

Adds documentation to many different Encodable implementations and inner encoding methods, to better explain how transactions are encoded.

Docs that existed above impl Encodable or impl Decodable are now above the encode or decode methods.

@Rjected Rjected added C-docs An addition or correction to our documentation C-enhancement New feature or request labels Jan 2, 2024
@Rjected Rjected force-pushed the dan/improve-rlp-transaction-decoding-docs branch from adae7ac to f4a520c Compare January 2, 2024 16:53
@Rjected Rjected force-pushed the dan/improve-rlp-transaction-decoding-docs branch from f4a520c to 016177e Compare January 2, 2024 16:56
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Rjected Rjected added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit dcf1d50 Jan 2, 2024
27 checks passed
@Rjected Rjected deleted the dan/improve-rlp-transaction-decoding-docs branch January 2, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs An addition or correction to our documentation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants