Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: simplify Database impls #5951

Merged
merged 1 commit into from
Jan 5, 2024
Merged

chore: simplify Database impls #5951

merged 1 commit into from
Jan 5, 2024

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Jan 5, 2024 •
edited
Loading

It's strange that DatabaseRef is not very useful.
Maybe the upstream revm should always impl DatabaseRef for type T: Database or offer a wrapper type directly.

mattsse
mattsse approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, we can indeed do that

@mattsse mattsse added this pull request to the merge queue Jan 5, 2024
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jan 5, 2024
Merged via the queue into paradigmxyz:main with commit 2a4d02f Jan 5, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yjhmelody @mattsse