-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bin): process metrics version mismatch #5985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the test, but this should probably be used to fix non-nextest test runs:
reth/bin/reth/src/builder/mod.rs
Lines 106 to 110 in 3d80e7f
/// The default prometheus recorder handle. We use a global static to ensure that it is only | |
/// installed once. | |
pub static PROMETHEUS_RECORDER_HANDLE: Lazy<PrometheusHandle> = | |
Lazy::new(|| prometheus_exporter::install_recorder().unwrap()); |
bin/reth/src/prometheus_exporter.rs
Outdated
fn process_metrics() { | ||
let handle = install_recorder().unwrap(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fails if running with cargo test --workspace --tests
:
failures:
cli::tests::parse_env_filter_directives
prometheus_exporter::tests::process_metrics
reason: recorder installed twice
dc50ae5
to
c0fcd1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, unblocking for release - other test failures are unrelated to this PR
reth/bin/reth/src/prometheus_exporter.rs
Lines 247 to 248 in 3d80e7f