Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use cfg attributes over macro #5999

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix: use cfg attributes over macro #5999

merged 1 commit into from
Jan 10, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 10, 2024

closes #5996

relevant part of cfg! macro docs:

cfg!, unlike #[cfg], does not remove any code and only evaluates to true or false. For example, all blocks in an if/else expression need to be valid when cfg! is used for the condition, regardless of what cfg! is evaluating.

@mattsse mattsse requested review from shekhirin and removed request for rakita and joshieDo January 10, 2024 10:21
@mattsse mattsse added the C-bug An unexpected or incorrect behavior label Jan 10, 2024
@shekhirin shekhirin added this pull request to the merge queue Jan 10, 2024
@shekhirin shekhirin mentioned this pull request Jan 10, 2024
Merged
Merged via the queue into main with commit 0588fa4 Jan 10, 2024
27 checks passed
@shekhirin shekhirin deleted the matt/fix-process-id branch January 10, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

Assignees
No one assigned
Labels
C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recent commit with MDBX bindings broke windows builds
2 participants
@mattsse @shekhirin