fix: change vergen features to match foundry #6047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package is used by both foundry and reth, with mutually exclusive features. This changes the features to match foundry where applicable, specifically using `git2` instead of `gitcl`
Rjected
added
C-bug
Rjected
requested review from
rakita,
joshieDo,
onbjerg and
gakonst
as code owners
gakonst
approved these changes
Jan 12, 2024
mattsse
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is used by both foundry and reth, with mutually exclusive features. This changes the features to match foundry where applicable, specifically using
git2instead ofgitclFixes #6044
There is another compile error in the repro after using this branch, but that can be resolved by using
features = ["optimism"]inreth-providers