Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve HashedStorage #6068

Merged
merged 11 commits into from
Jan 15, 2024
Merged

chore: improve HashedStorage #6068

merged 11 commits into from
Jan 15, 2024

Conversation

yjhmelody
Copy link
Contributor

No description provided.

rkrasiuk
rkrasiuk reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is cleaner

crates/trie/src/hashed_cursor/post_state.rs Outdated Show resolved Hide resolved
@rkrasiuk rkrasiuk added C-debt Refactor of code section that is hard to understand or maintain A-trie Related to Merkle Patricia Trie implementation labels Jan 15, 2024
onbjerg
onbjerg approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkrasiuk
Copy link
Member

let's get rid of the extra functions as suggested above. PR will need to be rebased once #6066 is merged

rkrasiuk
rkrasiuk reviewed Jan 15, 2024
View reviewed changes
crates/trie/src/state.rs Outdated Show resolved Hide resolved
@rkrasiuk rkrasiuk added this pull request to the merge queue Jan 15, 2024
Merged via the queue into paradigmxyz:main with commit 38559a9 Jan 15, 2024
27 checks passed
@yjhmelody yjhmelody deleted the chore-improve-HashedStorage branch January 16, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@onbjerg onbjerg onbjerg approved these changes

@rakita rakita Awaiting requested review from rakita

@joshieDo joshieDo Awaiting requested review from joshieDo

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yjhmelody @rkrasiuk @onbjerg