Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable eth_getProof hive test #7710

Merged
merged 1 commit into from
Apr 18, 2024
Merged

ci: enable eth_getProof hive test #7710

merged 1 commit into from
Apr 18, 2024

Conversation

KolbyML
Copy link
Contributor

@KolbyML KolbyML commented Apr 17, 2024 •
edited
Loading

From these PR's being complete
#5071
#2067

And this issue being resolved
#2046

I'm assuming eth_getProof hive tests can be enabled now?

mattsse
mattsse reviewed Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defer to @rkrasiuk

@mattsse mattsse added the C-test A change that impacts how or what we test label Apr 17, 2024
@rkrasiuk
Copy link
Member

@KolbyML do eth_getProof tests also query for historical proofs?

@KolbyML
Copy link
Contributor Author

KolbyML commented Apr 18, 2024

Didn't check, I will look in the morning

@onbjerg
Copy link
Member

onbjerg commented Apr 18, 2024

It doesn't do historical (for now at least). There are three tests:

  • One that fetches with a block hash which requests for the block with hash 0x8f64c4436f7213cfdf02cfb9f45d012f1774dfb329b8803de5e7479b11586902
  • One that fetches for latest
  • One that fetches for latest with storage

The tests: https://github.com/ethereum/execution-apis/blob/main/tests/eth_getProof

The chain.rlp is generated using https://github.com/lightclient/rpctestgen and the FCU matches 0x8f64c4436f7213cfdf02cfb9f45d012f1774dfb329b8803de5e7479b11586902: https://github.com/lightclient/rpctestgen/blob/main/chain/headfcu.json

onbjerg
onbjerg approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (because of above)

@rkrasiuk rkrasiuk added this pull request to the merge queue Apr 18, 2024
Merged via the queue into paradigmxyz:main with commit 027f920 Apr 18, 2024
28 checks passed
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
@KolbyML @mw2000
ci: enable eth_getProof hive test (paradigmxyz#7710)
eeab39f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@onbjerg onbjerg onbjerg approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@Rjected Rjected Awaiting requested review from Rjected

Assignees

@rkrasiuk rkrasiuk

Labels
C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KolbyML @rkrasiuk @onbjerg @mattsse