-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Separate database integration from trie
into its own crate
#8599
refactor: Separate database integration from trie
into its own crate
#8599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unequipped to review these code changes and there are quite a few @rkrasiuk
my original idea was to extract the types instead (especially trieupdates) and then work towards making them not dependent on the db deps.
but this approach also works, but I'm not sure about these changes, because using wrapper types to implement a trait is not ideal.
I assume it would be more useful to have
trie-types and trie
wdyt @rkrasiuk
perhaps we kick this off by extracting these: to trie-types instead and then try to move more stuff from reth-trie there? |
…eneric one Replace database specific types with an abstraction
Hey @mattsse, thank you for reviewing my PR so swiftly. So far I've been thinking that crates:
I haven't looked into the |
Superseded by #9282 |
Closes #8514