chore(net): enable rust.unnameable-types = "warn" lint #9505
Conversation
TropicalDog17
requested review from
emhane,
mattsse,
Rjected and
gakonst
as code owners
TropicalDog17
changed the title
Cargo.toml
Outdated
| @@ -155,6 +155,7 @@ rust.unreachable_pub = "warn" | |||
| rust.unused_must_use = "deny" | |||
| rust.rust_2018_idioms = { level = "deny", priority = -1 } | |||
| rustdoc.all = "warn" | |||
| rust.unnameable-types = "warn" | |||
There was a problem hiding this comment.
If we are going to solve these crate-by-crate, we have to remove this:
| rust.unnameable-types = "warn" |
And instead apply the lint just on the net crates, otherwise it will not be possible to merge this until fixes for all crates are applied
| @@ -155,6 +155,7 @@ rust.unreachable_pub = "warn" | |||
| rust.unused_must_use = "deny" | |||
| rust.rust_2018_idioms = { level = "deny", priority = -1 } | |||
| rustdoc.all = "warn" | |||
| # rust.unnameable-types = "warn" | |||
There was a problem hiding this comment.
remove this and add it to the Cargo.toml of each of the crates in net instead under [lints]
There was a problem hiding this comment.
yeah I don't think this is possible, I got the error when make lint :
cannot override `workspace.lints` in `lints`, either remove the overrides or `lints.workspace = true` and manually specify the lints
There was a problem hiding this comment.
we can keep this here until we can finally enable this and continue prs crate by crate imo
Description
Partially addresses #9401
Fix
unnameable-typeswarnings onnetcrate