Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support DNS in reth.toml for trusted_nodes #9864

Merged
merged 4 commits into from
Jul 31, 2024
Merged

feat: support DNS in reth.toml for trusted_nodes #9864

merged 4 commits into from
Jul 31, 2024

Conversation

loocapro
Copy link
Contributor

Closes: #9767

@onbjerg onbjerg changed the title Feat: DNS in reth.toml > trusted_nodes Feat: support DNS in reth.toml for trusted_nodes Jul 29, 2024
@onbjerg onbjerg added C-enhancement New feature or request A-networking Related to networking in general labels Jul 29, 2024
onbjerg
onbjerg approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@onbjerg onbjerg changed the title Feat: support DNS in reth.toml for trusted_nodes feat: support DNS in reth.toml for trusted_nodes Jul 29, 2024
onbjerg
onbjerg requested changes Jul 29, 2024
View reviewed changes
crates/net/network-types/src/peers/config.rs Outdated Show resolved Hide resolved
crates/net/network-types/src/peers/config.rs Outdated Show resolved Hide resolved
mattsse
mattsse requested changes Jul 29, 2024
View reviewed changes
crates/net/network-types/src/peers/config.rs Outdated Show resolved Hide resolved
crates/net/network-types/src/peers/config.rs Outdated Show resolved Hide resolved
@loocapro loocapro requested review from mattsse and onbjerg July 29, 2024 14:00
mattsse
mattsse requested changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style nit

crates/net/network/src/peers.rs Outdated Show resolved Hide resolved
crates/net/network/src/peers.rs Outdated Show resolved Hide resolved
@loocapro loocapro requested a review from mattsse July 30, 2024 08:29
@mattsse mattsse enabled auto-merge July 30, 2024 10:08
@mattsse mattsse added this pull request to the merge queue Jul 31, 2024
Merged via the queue into paradigmxyz:main with commit fcbdbf3 Jul 31, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg onbjerg approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support DNS names in trusted_nodes in reth.toml
3 participants
@loocapro @onbjerg @mattsse