Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): enable referencing network type via FullNodeComponents::Network #9921

Merged
merged 7 commits into from
Aug 1, 2024
Merged

chore(sdk): enable referencing network type via FullNodeComponents::Network #9921

merged 7 commits into from
Aug 1, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Jul 31, 2024 •
edited
Loading

Ref #9872

  • Adds associated types FullNodeComponents::Network and NodeComponents::Network
  • Passes network type from reth-node-builder to EthApi and OpEthApi via FullNodeComponents

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Jul 31, 2024
@emhane emhane changed the base branch from main to emhane/network-types July 31, 2024 00:03
Base automatically changed from emhane/network-types to main July 31, 2024 20:21
@emhane emhane marked this pull request as draft July 31, 2024 21:25
@emhane emhane marked this pull request as ready for review July 31, 2024 21:52
@emhane emhane changed the base branch from main to emhane/network-traits July 31, 2024 21:53
mattsse
mattsse approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense and would make it possible to configure any type of network eventually

Base automatically changed from emhane/network-traits to main August 1, 2024 17:03
@emhane emhane enabled auto-merge August 1, 2024 17:36
@emhane emhane added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit c71c813 Aug 1, 2024
33 checks passed
@emhane emhane deleted the emhane/fullnodecomponents branch August 1, 2024 18:09
@mattsse mattsse mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse