Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add OP cli flag to opt-in into discv4 discovery #9938

Merged
merged 3 commits into from
Aug 1, 2024
Merged

feat: Add OP cli flag to opt-in into discv4 discovery #9938

merged 3 commits into from
Aug 1, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Jul 31, 2024

towards #9919

Rjected
Rjected reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just want to confirm what we want w.r.t ux

crates/optimism/node/src/node.rs Outdated Show resolved Hide resolved
@nkysg @Rjected
Update crates/optimism/node/src/node.rs
7d2c342 
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@mattsse mattsse added the A-op-reth Related to Optimism and op-reth label Jul 31, 2024
Rjected
Rjected approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

mattsse
mattsse requested changes Jul 31, 2024
View reviewed changes
crates/optimism/node/src/node.rs Outdated Show resolved Hide resolved
@nkysg nkysg requested a review from mattsse August 1, 2024 07:30
@mattsse mattsse added this pull request to the merge queue Aug 1, 2024
Merged via the queue into paradigmxyz:main with commit 321032f Aug 1, 2024
32 checks passed
@nkysg nkysg deleted the op_disable_v4 branch August 1, 2024 12:41
@mattsse mattsse mentioned this pull request Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Rjected approved these changes

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkysg @Rjected @mattsse