Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(trie): use reth-storage-errors for DatabaseError type #9951

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jul 31, 2024

Ref #8514, #9282 (comment)

Supersedes #9937

DatabaseError is in reth-storage-errors crate that doesn't have any DB dependencies, so we can safely use it for our goal of making the trie independent of DB crates.

@shekhirin shekhirin added C-debt Refactor of code section that is hard to understand or maintain A-trie Related to Merkle Patricia Trie implementation labels Jul 31, 2024
@shekhirin shekhirin marked this pull request as ready for review July 31, 2024 16:48
@shekhirin shekhirin requested a review from mattsse July 31, 2024 16:48
@mattsse mattsse added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 6a19d27 Jul 31, 2024
33 checks passed
@mattsse mattsse deleted the alexey/trie-reth-storage-errors branch July 31, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants