fix: do not truncate blocks to persist #9986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C-perf
mattsse
approved these changes
Aug 1, 2024
Comment on lines
+769
to
+771
| /// Returns a batch of consecutive canonical blocks to persist in the range | ||
| /// `(last_persisted_number .. canonical_head - threshold]` . The expected | ||
| /// order is oldest -> newest. |
Comment on lines
783
to
785
| if block.block.number <= last_persisted_number { | ||
| break; | ||
| } |
There was a problem hiding this comment.
I believe this should actually be enforced by the tree invariants, but better be safe here
Comment on lines
+787
to
+789
| if block.block.number <= target_number { | ||
| blocks_to_persist.push(block.clone()); | ||
| } |
There was a problem hiding this comment.
this will work because we have a guarantee that canonical head always has its parent blocks
| /// oldest -> newest. | ||
| /// Returns a batch of consecutive canonical blocks to persist in the range | ||
| /// `(last_persisted_number .. canonical_head - threshold]` . The expected | ||
| /// order is oldest -> newest. | ||
| fn get_canonical_blocks_to_persist(&self) -> Vec<ExecutedBlock> { |
There was a problem hiding this comment.
could this return an empty vec?
if so we likely should add a sanity check before we send that vec to the persistence task
There was a problem hiding this comment.
sure, added here 45fbe9e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9978