Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move remove_blocks_above to StorageWriter #9997

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Aug 1, 2024

No description provided.

@joshieDo joshieDo added A-db Related to the database A-static-files Related to static files labels Aug 1, 2024
@joshieDo joshieDo enabled auto-merge August 1, 2024 16:52
StorageWriter::from(&provider_rw, &sf_provider)
.remove_blocks_above(new_tip_num)
.expect("todo: handle errors");
StorageWriter::commit_unwind(provider_rw, sf_provider)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

highlighting

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@joshieDo joshieDo added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit 333dbde Aug 1, 2024
33 checks passed
@joshieDo joshieDo deleted the joshie/mvrm branch August 1, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database A-static-files Related to static files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants