Issue #153: Add support for SameSite cookie flag #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for SameSite cookie flag in PHP >= 7.3.0. I split this out as a separate if statement to keep existing functionality in 7.2.x as similar as possible. When dropping support for 7.2.x, the idea would be to turn the method into just what's in side the version-comparing `if`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for Issue #153, which I created.
Add support for SameSite cookie flag in PHP >= 7.3.0. I split this out as a separate if statement to keep existing functionality in 7.2.x as similar as possible. When dropping support for 7.2.x, the idea would be to turn the method into just what's in side the version-comparing
if.This is my first time contributing here. I attempted to match code style and ensured all of the tests passed on my machine, but please let me know if there's anything that I can change to match your guidelines. I'm also happy to discuss and change the implementation details.