Refactor Get Resources into Filterable Resource List PBR component #1363

rolfheij-sil · 2024-12-02T16:10:15Z

This PR:

moves the Get Resources extension from Platform Bible Internal Extensions into Core
creates a new Home extension that is basically a copy of Get Resources for now
refactors Get Resources into a reusable component named Filterable Resource List

This PR does not update the Get Resources implementation in any way, so the code in FilterableResourceList.component.tsx has already been reviewed in this PR

This change is

… 93d4b0a63 git-subtree-dir: extensions/src/platform-get-resources git-subtree-split: 93d4b0a6364a69340364e47ddfb3c58e183e49c5

…s/src/platform-get-resources'

git-subtree-dir: extensions/src/platform-home git-subtree-split: 93d4b0a6364a69340364e47ddfb3c58e183e49c5

…s/src/platform-home'

…-home-extension

tjcouch-sil

Looking good! Thanks :) just a few little things.

Reviewed 75 of 100 files at r1, 29 of 29 files at r2, all commit messages.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @rolfheij-sil)

extensions/src/platform-get-resources/LICENSE line 3 at r2 (raw file):

MIT License

Copyright (c) <year> <copyright_holder_name>

Need to fill license copyrights in :)

extensions/src/platform-home/LICENSE line 3 at r2 (raw file):

MIT License

Copyright (c) <year> <copyright_holder_name>

Copyright

assets/localization/en.json line 7 at r2 (raw file):

  "%about_db_ip_attribution_intro%": "Internet safety features use data from",
  "%about_db_ip_attribution_terms%": "Terms",
  "%downloadResources_errorRegistrationInvalid%": "User registration is not valid. Cannot retrieve resources from DBL.",

Technically we're not supposed to remove localized strings because that's a breaking change 😬 it's fine this once since these are suuuuper specific strings that probably haven't been and won't be used elsewhere. But let's avoid removing strings in the future :)

extensions/src/platform-get-resources/src/main.ts line 23 at r2 (raw file):

    return {
      allowPopups: true,

What is this for? I think it may not be needed

extensions/src/platform-home/README.md line 5 at r2 (raw file):

Home screen extension for Platform.Bible

<!-- <!-- Opening comment tag for Template Info Section. Ignore this for now. More info in [Hide Template Info](#hide-template-info). -->

Commented?

extensions/src/platform-home/package.json line 94 at r2 (raw file):

  },
  "volta": {
    "node": "20.18.0"

Volta extend

extensions/src/platform-get-resources/README.md line 5 at r2 (raw file):

Get resources extension for Platform.Bible

<!-- <!-- Opening comment tag for Template Info Section. Ignore this for now. More info in [Hide Template Info](#hide-template-info). -->

I think this section still need to be hidden

extensions/src/platform-home/src/main.ts line 23 at r2 (raw file):

    return {
      allowPopups: true,

Also theorize this may not be needed

extensions/src/platform-get-resources/package.json line 93 at r2 (raw file):

    "zip-build": "^1.8.0"
  },
  "volta": {

To match other extensions, please change this to the following:

"volta": {
    "extends": "../../package.json"
  }

rolfheij-sil

Thanks for reviewing! :)

Reviewed 74 of 100 files at r1, 12 of 29 files at r2, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @tjcouch-sil)

assets/localization/en.json line 7 at r2 (raw file):