Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Aura Consensus Hook should enforce the relay-parent slot is equal to the Aura slot #2588

Closed
rphmeier opened this issue May 17, 2023 · 1 comment
Assignees
Labels
I7-refactor Code needs refactoring.

Comments

@rphmeier
Copy link
Contributor

#2551 introduced a ConsensusHook for Aura based on #2501 .

We require for Aura that the slot for parachains is set based on the slot of the relay-parent, as it's the only reliable indication of time we have access to within parachain runtimes. These checks are currently done through the parachain_system::CheckInherents trait that is evaluated during validate_block. Moving this check to the consensus hook would make it run during all block executions - both during validate_block and vanilla execute_block as used by parachain nodes. It is also a refactoring to make the logic more clear.

@slumber
Copy link
Contributor

slumber commented Jul 13, 2023

#2658

@slumber slumber closed this as completed Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I7-refactor Code needs refactoring.
Projects
None yet
Development

No branches or pull requests

2 participants