This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Adds support for checking the timestamp inherent while validating a block #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock This adds support for checking the timestamp inherent while validating a block. This will use the relay chain slot number * relay chain slot duration to calculate a timestamp. This timestamp is used to check the timestamp in the timestamp inherent.
| let inherent_data = | ||
| cumulus_primitives_timestamp::InherentDataProvider::from_relay_chain_slot_and_duration( | ||
| relay_chain_slot, | ||
| sp_std::time::Duration::from_secs(6), |
There was a problem hiding this comment.
this needs to be hardcoded?
There was a problem hiding this comment.
Maybe create a const for RELAY_SLOT_DURATION.
| let inherent_data = | ||
| cumulus_primitives_timestamp::InherentDataProvider::from_relay_chain_slot_and_duration( | ||
| relay_chain_slot, | ||
| sp_std::time::Duration::from_secs(6), |
There was a problem hiding this comment.
also must be hardcoded here?
andresilva
approved these changes
Jun 15, 2021
| let inherent_data = | ||
| cumulus_primitives_timestamp::InherentDataProvider::from_relay_chain_slot_and_duration( | ||
| relay_chain_slot, | ||
| sp_std::time::Duration::from_secs(6), |
There was a problem hiding this comment.
Maybe create a const for RELAY_SLOT_DURATION.
shawntabrizi
approved these changes
Jun 15, 2021
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
|
bot merge |
|
Trying merge. |
chevdor
pushed a commit
to chevdor/cumulus
that referenced
this pull request
Jun 24, 2021
…lock (paritytech#494) * Adds support for checking the timestamp inherent while validating a block This adds support for checking the timestamp inherent while validating a block. This will use the relay chain slot number * relay chain slot duration to calculate a timestamp. This timestamp is used to check the timestamp in the timestamp inherent. * Update polkadot-parachains/rococo-runtime/src/lib.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> * Update polkadot-parachains/statemine-runtime/src/lib.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> * Update primitives/timestamp/src/lib.rs Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> * Fix warnings Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for checking the timestamp inherent while validating a
block. This will use the relay chain slot number * relay chain slot
duration to calculate a timestamp. This timestamp is used to check the
timestamp in the timestamp inherent.
Fixes: #422