Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to HaulBlobExporter and BridgeBlobDispatcher from polkadot repo #1576

Closed
Tracked by #1706
svyatonik opened this issue Sep 20, 2022 · 5 comments
Closed
Tracked by #1706
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@svyatonik
Copy link
Contributor

The fact that these types can't be used from outside is a bug. Right now we have a copy in the bridge-runtime-common crate. This copy shall be removed and the original XCM v3 PR shall be fixed so that the "all pub types in universal_exports.rs should be reexported from lib.rs".

@svyatonik svyatonik added the dependencies Pull requests that update a dependency file label Sep 20, 2022
@bkontur
Copy link
Contributor

bkontur commented Sep 20, 2022

@svyatonik
Slava, I would love to take this as a good start to dive into xcm bridge messaging, ok?

@svyatonik
Copy link
Contributor Author

@bkontur
Sure, imo it involves three steps:

  1. opening separate PR some-branch -> gav-xcm-v3 with "all pub types in universal_exports.rs should be reexported from lib.rs". We may also ask if an isolated commit directly to the gav-xcm-v3 would work here;
  2. updating our refs to the latest gav-xcm-v3
  3. actually using those types. TBH I'm not sure if they are currently used in Rialto/RialtoParachain<>Milau - I've had too many troubles with using them back when we've been switching to the XCM messaging. This may take a while and require many changes. In any case - if you'll have troubles here, let's chat/discuss later

@EmmanuellNorbertTulbure
Copy link

@bkontur status on this one?

@EmmanuellNorbertTulbure
Copy link

EmmanuellNorbertTulbure commented Mar 7, 2023

When closing, the questions from the PR should be transferred into issue(s).
PR: #1813. (Reffering to the message weight and how many can be sent)

@bkontur
Copy link
Contributor

bkontur commented Mar 13, 2023

@EmmanuellNorbertTulbure PR is closed and I guess, the only thing, which is not in any issue, is just this test: #1813 (comment)

@bkontur bkontur closed this as completed Mar 13, 2023
svyatonik pushed a commit that referenced this issue Jul 17, 2023
* Add rules and specs

* add labels

* Add new checks

* Fix criticality check

* Use the new rule filter introduced in ruled-labels v0.3.0 to better target tests

* Add workflow to tests label rules

* Fix trigger

* Add new GH Workflow

* Don't swallow failures but allow them

* Fix new script

* Simplify check

* Fix Workflow

* Remove dup var

* Fix vars

* Move pull image to separate step

* Remove continue on error

* Show input list of labels

* Fix check-labels workflow

* Remove Docker -it flags

* Prevent shell from splitting on spaces

* Fix rules path

* Comment out rules related to labels not present in the repo

* Fix tests

* Fix labels specs and tests

* fix test

* new label description and rules

* fix tests

* use ruled_labels as crate

* fix toolchain

* fix component

* move from docker to crate

* fix test

* fail without labels

* add cache

* fix check no labels

* add D-labels check

* fix emtpy label check

* try docker

* fix specs

* test D label

* revert Cargo.toml

* use tags for ruled_labels

* fix rules

* test D label

* fix tags

* remove changes

* add PR tag to single criticality rule

* remove old line

* test ruled_labels test

* disable Check label Rules

* fix GHA name

* fix tests

* rename files, upd ruled_labels 0.3.2

Co-authored-by: alvicsam <alvicsam@gmail.com>
Co-authored-by: parity-processbot <>
Co-authored-by: Joyce Siqueira <joycesiqueira@Joyces-MacBook-Pro.local>
Co-authored-by: joyce <joyce@parity.io>
Co-authored-by: Joyce Siqueira <98593770+the-right-joyce@users.noreply.github.com>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants