Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace LaneId with TypedLaneId #1694

Closed
svyatonik opened this issue Dec 2, 2022 · 0 comments · Fixed by #1738
Closed

Replace LaneId with TypedLaneId #1694

svyatonik opened this issue Dec 2, 2022 · 0 comments · Fixed by #1738
Labels
A-chores Something that has to be done, as part of regular maintenance Good First Issue Good for newcomers
Milestone
When Thou Have Sp...

Comments

@svyatonik
Copy link
Contributor

We don't actually need two types - TypedLaneId is just to be able to use it for account id generation. So they must be merged. I.e.:

  • remove LaneId;
  • rename TypedLaneId to LaneId.

They must stay SCALE-compatible with each other - everything that changes is that we're wrapping [u8; 4] into specific type.
@svyatonik svyatonik added Good First Issue Good for newcomers A-chores Something that has to be done, as part of regular maintenance labels Dec 2, 2022
@svyatonik svyatonik added this to the When Thou Have Spare Hour milestone Dec 2, 2022
@svyatonik svyatonik mentioned this issue Dec 2, 2022
Merged
@svyatonik svyatonik mentioned this issue Dec 30, 2022
Merged
svyatonik pushed a commit that referenced this issue Jul 17, 2023
@gilescope @paritytech-ci
[benchmarks] pr with weights (#1664) (#1694)
facb089 
Co-authored-by: paritytech-ci <paritytech-ci@parity.io>

Co-authored-by: Paritytech CI <52199148+paritytech-ci@users.noreply.github.com>
Co-authored-by: paritytech-ci <paritytech-ci@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-chores Something that has to be done, as part of regular maintenance Good First Issue Good for newcomers
Projects
None yet
Milestone
When Thou Have Spare Hour
Development

Successfully merging a pull request may close this issue.

Use TypedLaneId instead of LaneId paritytech/parity-bridges-common
1 participant
@svyatonik