Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using indirect runtime calls for RialtoParachain #1745

Closed
serban300 opened this issue Jan 9, 2023 · 2 comments · Fixed by #1753
Closed

Consider using indirect runtime calls for RialtoParachain #1745

serban300 opened this issue Jan 9, 2023 · 2 comments · Fixed by #1753
Assignees

Comments

@serban300
Copy link
Collaborator

At the moment we use direct runtime calls for all the runtimes that are defined in this repo. The problem with this is that we don't have any way to test that the indirect runtime calls logic works within our test deployments. So for example if there is any issue with the indirect runtime logic calls we will find out only after we deploy it to rococo/wococo.

If we used the indirect call logic for one of the runtimes that are defined in this repo, we would catch many potential issues as part of our test deployments. For example I think it would be the easiest to use this for RialtoParachain.

Context:
By direct runtime call I'm referring to using the runtime calls defined by construct_runtime!(). We can do this only for the runtimes defined in our repo. For example for rialto parachain. While for runtimes that are not defined in our repo we use "indirect runtime calls", which is are basically a mock of the runtime. For example bridge hub rococo.

@svyatonik do you think this would make sense ?

@serban300 serban300 self-assigned this Jan 9, 2023
@svyatonik
Copy link
Contributor

Yeah - we may do that. But imo for external runtimes we'll need some more sophisticated testing - there's a lot that can break and we won't be able to detect that by only testing it on RialtoParachain - e.g. pallet index, call change, upgrading only one side of the bridge, ... So probably we'll need some tool (can we use zombienet for that?) that will spin up (local) upgraded chains and will start required relayers and will say us that everything went smoothly.

But in any case - having it on RialtoParachain sounds good to me.

@serban300
Copy link
Collaborator Author

Makes sense. I posted #1753 for using indirect calls on RialtoParachain and after that I'll open another issue for adding more sophisticated testing for indirect runtimes.

svyatonik pushed a commit that referenced this issue Jul 17, 2023
* Bump to clap4

* Adjust to clap 4 style

* Remove two more deprecated occurences of clap macro

* Remove "deprecated" feature from clap

* Update cargo lock

* Fix group name

* More skipped group names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants