Reuse polkadot-service code #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
the
A-chores
|
on hold, until I'll solve #1268 (comment) UPD: let's move all benchmarks to Millau. I think we may solve the cargo issues I'm seeing when trying to compile benchmarks now, but then we'll be building all 4 polkadot runtimes (P/K/W/R) anyway, which is not good. Later we may reconsider that |
|
looks like this is unblocked now |
|
Yeah - it is ready for review :) |
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 3. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v2...v3) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1136
Unfortunately,
polkadot-runtimeis still requirespolkadot-service(actually - one of P/K/W/R runtimes is now required - I've selected polkadot). If it isn't selected, no runtime-features ofpolkadot-clientare activated and I'm getting this error.But at least I've been able to reuse
polkadot-serviceand remove our customservice.rs,overseer.rsandparachains_db.rs(which is a lot of code).