Support version mode CLI options in send-message subcommand #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
commented
Jan 14, 2022
| @@ -110,6 +116,10 @@ impl SendMessage { | |||
|
|
|||
| encode_call::preprocess_call::<Source, Target>(message, bridge.bridge_instance_index()); | |||
| let target_call = Target::encode_call(message)?; | |||
| let target_spec_version = self | |||
There was a problem hiding this comment.
That's the main change - instead of always using Target::RUNTIME_VERSION.spec_version below, I'm using version based on CLI flags
acatangiu
approved these changes
Jan 14, 2022
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
* Node bump to v0.9.220 * Runtime version bump to 922 (#1283) * Runtime version bump to 922 * Switch to 9220 * Update cargo.lock
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1283
So right now Rococo has runtime version
9141and Wococo is9140. "Release" relay thinks that both have9140. Since they're testnets, this is fine (given that headers+messages relay is running with*-version-mode=AutoCLI option). But relay still uses9140when encoding messages from Wococo to Rococo, meaning that they'll be delivered, but dispatch will fail withMessageVersionSpecMismatcherror. This PR allows message submitter to provide custom version or to read actual version from the target node.