-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump polkadot/substrate #2134
Bump polkadot/substrate #2134
Conversation
@@ -49,6 +49,25 @@ pub struct GrandpaJustification<Header: HeaderT> { | |||
pub votes_ancestries: Vec<Header>, | |||
} | |||
|
|||
// TODO: remove and use `RuntimeDebug` (https://github.com/paritytech/parity-bridges-common/issues/2136) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svyatonik @serban300
I have no idea why this does not work in Cumulus for bridge-hub-rococo-runtime,
probably some Cargo.lock/Cargo.toml + features propagation problem or I missed something.
Tried severel things but nothing worked.
cargo check --all --features try-runtime
works for bridges repo and all rialto/millau runtimes, but does not work for Cumulus when RuntimeDebug
is used here, strange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll take a look, for sure. Thanks for filing an issue
* Nits (merge before separatelly) * Small cosmetics for Rococo/Wococo bridge local run * Squashed 'bridges/' changes from 04b3dda..5fc377a 5fc377a Support for kusama-polkadot relaying (#2128) 01f4b7f Fix clippy warnings (#2127) 696ff1c BHK/P alignments (#2115) 2a66aa3 Small fixes (#2126) 7810f1a Cosmetics (#2124) daf250f Remove some `expect()` statements (#2123) 1c5fba8 temporarily remove balance guard (#2121) 3d0e547 Propagate message receival confirmation errors (#2116) 1c33143 Propagate message verification errors (#2114) b075b00 Bump time from 0.3.20 to 0.3.21 51a3a51 Bump serde from 1.0.160 to 1.0.162 da88d04 Bump clap from 4.2.5 to 4.2.7 cdca322 Bump sysinfo from 0.28.4 to 0.29.0 git-subtree-dir: bridges git-subtree-split: 5fc377a * Fix * Allow to change storage constants (DeliveryReward, RequiredStakeForStakeAndSlash) + tests * Clippy * New SA for RO/WO * Squashed 'bridges/' changes from 5fc377a..0f6091d 0f6091d Bump polkadot/substrate (#2134) 9233f0a Bump tokio from 1.28.0 to 1.28.1 a29c1ca Bump serde from 1.0.162 to 1.0.163 git-subtree-dir: bridges git-subtree-split: 0f6091d
* Bump polkadot/substrate * Fix millau network service * Fix polkadot_node_core_pvf_worker * Fix sc-network * Fix parachain rpc stuff * Check `integrity-test` for `bridge-runtime-common` * Backport fix from cumulus https://github.com/paritytech/cumulus/pull/2585/files#diff-5a942d80670b5ef31bb18b5acacab93ff30512d7cd21c19d7da364f76f6bb5c3 because of https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2842938 * TODO * Bump cumulus
* Bump polkadot/substrate * Fix millau network service * Fix polkadot_node_core_pvf_worker * Fix sc-network * Fix parachain rpc stuff * Check `integrity-test` for `bridge-runtime-common` * Backport fix from cumulus https://github.com/paritytech/cumulus/pull/2585/files#diff-5a942d80670b5ef31bb18b5acacab93ff30512d7cd21c19d7da364f76f6bb5c3 because of https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2842938 * TODO * Bump cumulus
No description provided.