Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote externalities download slows down at the end #2096

Open
ggwpez opened this issue Oct 31, 2023 · 4 comments
Open

Remote externalities download slows down at the end #2096

ggwpez opened this issue Oct 31, 2023 · 4 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T1-FRAME This PR/Issue is related to core FRAME, the framework. T10-tests This PR/Issue is related to tests.

Comments

@ggwpez
Copy link
Member

ggwpez commented Oct 31, 2023

Somehow the remote externalities get slower at the end. This was determined to not be related to RPC rate limits but seems to be a problem of the externalities.
Our suspicion os that it is related to the size of the KV pairs.
A debug flag like --measure-dl-timing output.json could be added to measure and investigate the KV timings later on.

Example: normally around 12-14 kV/s, it slows down to 200-500 V/s. This was also noticed by @liamaharon.

image (1)

(Marking as mentor since adding the flag should be simple)

@ggwpez ggwpez added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T1-FRAME This PR/Issue is related to core FRAME, the framework. labels Oct 31, 2023
@ggwpez ggwpez changed the title Remote externalities key downloading slows down at the end Remote externalities download slows down at the end Oct 31, 2023
@eagr
Copy link
Contributor

eagr commented Nov 12, 2023

I noticed the related code is deprecated in favor of the standalone try-runtime-cli. Do you still want to do this here? @ggwpez @liamaharon

@liamaharon
Copy link
Contributor

I noticed the related code is deprecated in favor of the standalone try-runtime-cli. Do you still want to do this here? @ggwpez @liamaharon

This issue originates in remote-externalities, which try-runtime-cli depends on.

Same crate you are adding the parallel scraping to :)

@eagr
Copy link
Contributor

eagr commented Nov 12, 2023

Yeah, that part of the change definitely goes this repo. I mean the cli flag part. Do you still want to do that here? :))

@liamaharon
Copy link
Contributor

Yeah, that part of the change definitely goes this repo. I mean the cli flag part. Do you still want to do that here? :))

Seems it needs an issue in both repos. One to add the feature to remote-ext, and another to use it in try-runtime-cli

@ggwpez ggwpez added T10-tests This PR/Issue is related to tests. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Feb 5, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
bkchr pushed a commit that referenced this issue Apr 10, 2024
* add integrity tests to rialto-parachain runtime

* post cherry-pick fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T1-FRAME This PR/Issue is related to core FRAME, the framework. T10-tests This PR/Issue is related to tests.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants