Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cumulus] Clean parachains-common #3054

Open
2 of 12 tasks
bkontur opened this issue Jan 24, 2024 · 1 comment
Open
2 of 12 tasks

[cumulus] Clean parachains-common #3054

bkontur opened this issue Jan 24, 2024 · 1 comment
Assignees
@bkontur

Comments

@bkontur
Copy link
Contributor

bkontur commented Jan 24, 2024 •
edited
Loading

Context: Basti's comment
Continuation of #3041

TODO

  • create new module cumulus/parachains/runtimes/constants
    • move rococo.rs and westend.rs there (similar as polkadot-fellows has system-parachains-constants module)
  • move mod constants to the new module (fellows has its own copy already)
  • remove AssetHubPolkadotAuraId a move it to the polkadot-fellows
  • revisit mod types and mod opaque

Questions:

  • What about common types like: AccountId, Balance,.... Can we share them between polkadot-sdk and polkadot-fellows repo? Or better split all of them?
    • What is the purpose of these types here? To be shared/used:
      • by all parachains?
      • by testnets?
      • by fellows runtimes?
      • or should everybody defines them separately? (types for testnet parachains, types for fellows parachain in fellows repo, ...)
  • What about AssetHubPolkadotAuraId? It is used for some stuff in parachain-polkadot module e.g. here and/or here. Remove from parachains-common and have definitions on two places (somewhere in polkadot-parachain and polkadot-fellows)? Or leave as it is?
@bkontur bkontur self-assigned this Jan 24, 2024
This was referenced Jan 24, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 31, 2024
@bkontur @georgepisaltu
[cumulus] parachains-common testnet constants cleaning (#3134)
4450b61 
The `parachains-common` contains a lots of constants and type
definitions which are used for `polkadot-sdk`'s testnet runtimes and
also for `polkadot-fellows`'s production [SP
runtimes](https://github.com/polkadot-fellows/runtimes/tree/main/system-parachains/constants).
This PR cleans `parachains-common` module to contain only common and
generic functionality.

Testnet-specific constants have been moved to the separate module
dedicated just for testnets:
`polkadot-sdk/cumulus/parachains/runtimes/constants/`


Part of: #3054

---------

Co-authored-by: georgepisaltu <george.pisaltu@parity.io>
@seadanda
Copy link
Contributor

IMO for the AssetHubPolkadotAuraId having a definition in fellows and a definition in polkadot-parachain is the way to go, since it belongs with the fellowship and will never change anyway. Also it's just an alias.

@bkontur bkontur mentioned this issue Feb 13, 2024
Open
@bkontur bkontur mentioned this issue Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkontur bkontur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkontur @seadanda