Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON-RPC: chainHead_v1_storage started event is missing discardedItems property #6683

Closed
josepot opened this issue Nov 27, 2024 · 4 comments · Fixed by #6760
Closed

JSON-RPC: chainHead_v1_storage started event is missing discardedItems property #6683

josepot opened this issue Nov 27, 2024 · 4 comments · Fixed by #6760
Labels
I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@josepot
Copy link

josepot commented Nov 27, 2024

The started event of the chainHead_v1_storage operation is not spec compliant because is missing the discardedItems property.
@github-actions github-actions bot added the I10-unconfirmed Issue might be valid, but it's not yet known. label Nov 27, 2024
@josepot josepot mentioned this issue Nov 28, 2024
Merged
@josepot
Copy link
Author

josepot commented Dec 4, 2024

Ping @jsdw @IkerAlus @lexnv

@lexnv
Copy link
Contributor

lexnv commented Dec 4, 2024

Substrate implementation should no longer discard items because we rely entirely on backpressure, I'll have a quick look over the code, thanks for reporting this 🙏

@josepot
Copy link
Author

josepot commented Dec 4, 2024

Substrate implementation should no longer discard items because we rely entirely on backpressure, I'll have a quick look over the code, thanks for reporting this 🙏

even if it doesn't discard them, the discardedItems property should still be present and its value should be 0.

@lexnv
Copy link
Contributor

lexnv commented Dec 4, 2024

Yep exactly, I think we missed this during a refactoring, will patch it 🙏

@lexnv lexnv mentioned this issue Dec 4, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2024
@lexnv @actions-user
chainHead: Always report discarded items for storage operations (#6760)
df1375e 
This PR ensures that substrate always reports discarded items as zero.
This is needed to align with the rpc-v2 spec

Closes: #6683


cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: GitHub Action <action@github.com>
sylvaincormier pushed a commit to sylvaincormier/polkadot-sdk that referenced this issue Dec 5, 2024
@lexnv @actions-user @sylvaincormier
chainHead: Always report discarded items for storage operations (pari…
46aabe3 
…tytech#6760)

This PR ensures that substrate always reports discarded items as zero.
This is needed to align with the rpc-v2 spec

Closes: paritytech#6683


cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: GitHub Action <action@github.com>
lexnv added a commit that referenced this issue Dec 11, 2024
@lexnv @actions-user
chainHead: Always report discarded items for storage operations (#6760)
ee9fe2d 
This PR ensures that substrate always reports discarded items as zero.
This is needed to align with the rpc-v2 spec

Closes: #6683


cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: GitHub Action <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chainHead: Always report discarded items for storage operations paritytech/polkadot-sdk
2 participants
@josepot @lexnv