Remove AccountKeyring everywhere #5899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programskillforverification
force-pushed
the
remove-accountkeyring
branch
from
ca3893d to
4011fc8
Compare
programskillforverification
force-pushed
the
remove-accountkeyring
branch
from
600de1c to
d2b43c2
Compare
|
@programskillforverification can you please highlight with a comment the main place where AccountKeyring is defined and changed/removed? Lots of files here :P |
| @@ -32,20 +32,11 @@ pub mod ed25519; | |||
| #[cfg(feature = "bandersnatch-experimental")] | |||
| pub mod bandersnatch; | |||
|
|
|||
| /// Convenience export: Sr25519's Keyring is exposed as `AccountKeyring`, since it tends to be | |||
| /// used for accounts (although it may also be used by authorities). | |||
| pub use sr25519::Keyring as AccountKeyring; | |||
There was a problem hiding this comment.
@shawntabrizi AccountKeyring definition here
| #[cfg(feature = "bandersnatch-experimental")] | ||
| pub use bandersnatch::Keyring as BandersnatchKeyring; | ||
| pub use ed25519::Keyring as Ed25519Keyring; | ||
| pub use sr25519::Keyring as Sr25519Keyring; | ||
|
|
||
| pub mod test { | ||
| /// The keyring for use with accounts when using the test runtime. | ||
| pub use super::ed25519::Keyring as AccountKeyring; |
There was a problem hiding this comment.
@shawntabrizi and here
There was a problem hiding this comment.
doesn't seem this was used anywhere.
bkchr
approved these changes
Nov 29, 2024
bkchr
added
the
T17-primitives
auto-merge was automatically disabled
November 29, 2024 22:41
Pull Request is not mergeable
programskillforverification
force-pushed
the
remove-accountkeyring
branch
from
3c663ae to
7ece68f
Compare
bkchr
approved these changes
Nov 30, 2024
auto-merge was automatically disabled
December 9, 2024 09:09
Head branch was pushed to by a user without write access
bkchr
approved these changes
Dec 9, 2024
bkontur
approved these changes
Dec 10, 2024
Merged
via the queue into
paritytech:master
with commit Dec 10, 2024
311ea43
195 of 200 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #5858