chainHead: Always report discarded items for storage operations #6760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
|
/cmd prdoc --audience node_dev --bump patch |
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
niklasad1
approved these changes
Dec 4, 2024
niklasad1
added
the
A4-needs-backport
niklasad1
reviewed
Dec 4, 2024
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
bkchr
approved these changes
Dec 5, 2024
sylvaincormier
pushed a commit
to sylvaincormier/polkadot-sdk
that referenced
this pull request
Dec 5, 2024
…tytech#6760) This PR ensures that substrate always reports discarded items as zero. This is needed to align with the rpc-v2 spec Closes: paritytech#6683 cc @paritytech/subxt-team --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: GitHub Action <action@github.com>
lexnv
added a commit
that referenced
this pull request
Dec 11, 2024
This PR ensures that substrate always reports discarded items as zero. This is needed to align with the rpc-v2 spec Closes: #6683 cc @paritytech/subxt-team --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: GitHub Action <action@github.com>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Dec 11, 2024
…rage operations (#6842) Backport PR for: - #6760 cc @paritytech/subxt-team Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: GitHub Action <action@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that substrate always reports discarded items as zero.
This is needed to align with the rpc-v2 spec
Closes: #6683
cc @paritytech/subxt-team