Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

filter_multi_dispute_data should use with_transaction #4055

Closed
rphmeier opened this issue Oct 11, 2021 · 0 comments · Fixed by #4067
Closed

filter_multi_dispute_data should use with_transaction #4055

rphmeier opened this issue Oct 11, 2021 · 0 comments · Fixed by #4067
Labels
I8-refactor Code needs refactoring.

Comments

@rphmeier
Copy link
Contributor

https://crates.parity.io/frame_support/storage/fn.with_transaction.html

filter_multi_dispute_data updates storage, which means that the state after calling it is not fresh. It should instead run within a storage transaction whose result is rolled back after completion.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I8-refactor Code needs refactoring.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant