Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove check_web_wasm job #3654

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Remove check_web_wasm job #3654

merged 1 commit into from
Aug 17, 2021

Conversation

s3krit
Copy link
Contributor

@s3krit s3krit commented Aug 17, 2021

@s3krit s3krit added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 17, 2021
@s3krit s3krit mentioned this pull request Aug 17, 2021
Merged
dvdplm
dvdplm approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh is this why #9541 is stuck? You're my new best friend.

@s3krit
Copy link
Contributor Author

s3krit commented Aug 17, 2021

Oh is this why #9541 is stuck? You're my new best friend.

Nah, see my comment in #9541 for why it's stuck (required check hasn't yet been removed)

TriplEight
TriplEight approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TriplEight TriplEight merged commit dc213bd into master Aug 17, 2021
@TriplEight TriplEight deleted the mp-remove-check-web-wasm branch August 17, 2021 18:02
@TriplEight
Copy link
Contributor

check-web-wasm was not required for merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@TriplEight TriplEight TriplEight approved these changes

@expenses expenses Awaiting requested review from expenses

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s3krit @TriplEight @dvdplm