From c9c57317c9f159e3135fc77a40300f3b322240fb Mon Sep 17 00:00:00 2001 From: Marcin S Date: Fri, 25 Nov 2022 07:30:13 -0500 Subject: [PATCH 1/2] Provide some more granular metrics for polkadot_pvf_execution_time Previously the metrics were mostly clustered at under 100ms which wasn't very useful. Also, there were some jobs that finished between 6s and +Inf which likewise didn't tell us much. --- node/core/pvf/src/metrics.rs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/node/core/pvf/src/metrics.rs b/node/core/pvf/src/metrics.rs index 20965ec7dbd7..df00aa8b0ba2 100644 --- a/node/core/pvf/src/metrics.rs +++ b/node/core/pvf/src/metrics.rs @@ -183,6 +183,9 @@ impl metrics::Metrics for Metrics { ).buckets(vec![ // This is synchronized with `APPROVAL_EXECUTION_TIMEOUT` and // `BACKING_EXECUTION_TIMEOUT` constants in `node/primitives/src/lib.rs` + 0.01, + 0.025, + 0.05, 0.1, 0.25, 0.5, @@ -192,6 +195,10 @@ impl metrics::Metrics for Metrics { 4.0, 5.0, 6.0, + 7.0, + 8.0, + 9.0, + 10.0, ]), )?, registry, From c2db915d223a4bb5408a137c799e5852166b6bdf Mon Sep 17 00:00:00 2001 From: Marcin S Date: Fri, 25 Nov 2022 07:56:54 -0500 Subject: [PATCH 2/2] Adjust upper bound --- node/core/pvf/src/metrics.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/node/core/pvf/src/metrics.rs b/node/core/pvf/src/metrics.rs index df00aa8b0ba2..8db105d895ea 100644 --- a/node/core/pvf/src/metrics.rs +++ b/node/core/pvf/src/metrics.rs @@ -195,10 +195,9 @@ impl metrics::Metrics for Metrics { 4.0, 5.0, 6.0, - 7.0, 8.0, - 9.0, 10.0, + 12.0, ]), )?, registry,