From 4d1f40d4659c68d2c1c5e9fb6fb6fcaf4a56d853 Mon Sep 17 00:00:00 2001 From: Javier Bullrich Date: Wed, 3 Jul 2024 14:08:42 +0200 Subject: [PATCH] updated github actions to use latest major version (#128) This solves the problem that actions/cache was not working and removes all the warnings. --- .github/workflows/github-issue-sync.yml | 2 +- .github/workflows/javascript-test.yml | 23 ++++++++++++----------- .github/workflows/publish.yml | 14 +++++++------- 3 files changed, 20 insertions(+), 19 deletions(-) diff --git a/.github/workflows/github-issue-sync.yml b/.github/workflows/github-issue-sync.yml index 035bdbb..5a1b0f7 100644 --- a/.github/workflows/github-issue-sync.yml +++ b/.github/workflows/github-issue-sync.yml @@ -18,7 +18,7 @@ jobs: steps: - name: Generate token id: generate_token - uses: actions/create-github-app-token@v1.9.3 + uses: actions/create-github-app-token@v1 with: app-id: ${{ secrets.PROJECT_APP_ID }} private-key: ${{ secrets.PROJECT_APP_KEY }} diff --git a/.github/workflows/javascript-test.yml b/.github/workflows/javascript-test.yml index 14dbb78..a345e9c 100644 --- a/.github/workflows/javascript-test.yml +++ b/.github/workflows/javascript-test.yml @@ -11,20 +11,21 @@ jobs: name: running ${{ matrix.command }} timeout-minutes: 5 steps: - - uses: actions/checkout@v4.1.3 - - uses: actions/setup-node@v4.0.2 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 22 + - name: Get yarn cache directory path + id: yarn-cache-dir-path + run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT - name: Cache node modules - id: cache-npm - uses: actions/cache@v4.0.2 - env: - cache-name: cache-node-modules + id: yarn-cache + uses: actions/cache@v4 with: - # npm cache files are stored in `~/.npm` on Linux/macOS - path: ~/.npm - key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/yarn.lock') }} - restore-keys: ${{ runner.os }}-build-${{ env.cache-name }}- + path: ${{ steps.yarn-cache-dir-path.outputs.dir }} + key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} + restore-keys: | + ${{ runner.os }}-yarn- - name: Install dependencies run: yarn install --immutable - run: yarn run ${{ matrix.command }} diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index a2555bd..6309b55 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -13,14 +13,14 @@ jobs: test-image: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4.1.3 + - uses: actions/checkout@v4 - name: Check that the image builds run: docker build . --file Dockerfile validate-action: runs-on: ubuntu-latest if: github.event_name == 'pull_request' steps: - - uses: actions/checkout@v4.1.3 + - uses: actions/checkout@v4 # This checks that .github/workflows/review-bot.yml is pointing towards the main branch # as, during development, we change this to use the code from the test branch and # we may forget to set it back to main @@ -43,7 +43,7 @@ jobs: version: ${{ steps.verification.outputs.VERSION }} exists: ${{ steps.checkTag.outputs.exists }} steps: - - uses: actions/checkout@v4.1.3 + - uses: actions/checkout@v4 - name: Extract package.json version id: package_version run: echo "VERSION=$(jq '.version' -r package.json)" >> $GITHUB_OUTPUT @@ -68,14 +68,14 @@ jobs: contents: write packages: write steps: - - uses: actions/checkout@v4.1.3 + - uses: actions/checkout@v4 - name: Tag version and create release run: gh release create $VERSION --generate-notes env: VERSION: v${{ needs.compare-versions.outputs.version }} GH_TOKEN: ${{ github.token }} - name: Log in to the Container registry - uses: docker/login-action@v3.1.0 + uses: docker/login-action@v3 with: registry: ${{ env.REGISTRY }} username: ${{ github.actor }} @@ -86,9 +86,9 @@ jobs: with: images: ${{ env.REGISTRY }}/${{ github.repository }}/${{ env.IMAGE_NAME }} tags: ${{ needs.compare-versions.outputs.version }} - - uses: actions/checkout@v4.1.3 + - uses: actions/checkout@v4 - name: Build and push Docker image - uses: docker/build-push-action@v5.3.0 + uses: docker/build-push-action@v5 with: context: . push: true