Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking changes on v1.2.0 #118

Closed
Tracked by #8
Bullrich opened this issue Apr 23, 2024 · 0 comments · Fixed by #119
Closed
Tracked by #8

Breaking changes on v1.2.0 #118

Bullrich opened this issue Apr 23, 2024 · 0 comments · Fixed by #119
Assignees
@Bullrich
Labels
bug Something isn't working Fellows Tickets related to the fellowship

Comments

@Bullrich
Copy link
Contributor

There has been some breaking changes in the API that fails while fetching members:

https://github.com/polkadot-fellows/runtimes/actions/runs/8785455495/job/24106017259
@Bullrich Bullrich added the Fellows Tickets related to the fellowship label Apr 23, 2024
@Bullrich Bullrich mentioned this issue Apr 23, 2024
Closed
@Bullrich Bullrich self-assigned this Apr 23, 2024
@Bullrich Bullrich added the bug Something isn't working label Apr 23, 2024
@Bullrich Bullrich mentioned this issue Apr 23, 2024
Merged
@Bullrich Bullrich linked a pull request Apr 23, 2024 that will close this issue
Fix IdentityOf tuple introduced in v1.2.0 #119
Merged
Bullrich added a commit that referenced this issue Apr 23, 2024
@Bullrich
Fix IdentityOf tuple introduced in v1.2.0 (#119)
29e944c 
Fixed `Identity` object now being a tuple of type `[IdentityOf,
BoundedVec]` introduced as as breaking change in v1.2.0

Fixes #118
Bullrich added a commit to Bullrich/polkadot-fellows-runtimes that referenced this issue Apr 23, 2024
@Bullrich
updated review-bot to 2.4.1
ec47ac8 
This contains the fix for paritytech/review-bot#118, which is a breaking change introduced in V1.2.0 which causes the `Identity` object to become a tuple.

The updated code gets the first element of the tuple.
@Bullrich Bullrich mentioned this issue Apr 23, 2024
Merged
1 task
Bullrich added a commit to Bullrich/polkadot-fellows-runtimes that referenced this issue Apr 23, 2024
@Bullrich
updated review-bot to 2.4.1
36ef05f 
This contains the fix for paritytech/review-bot#118, which is a breaking change introduced in V1.2.0 which causes the `Identity` object to become a tuple.

The updated code gets the first element of the tuple.
bkchr pushed a commit to polkadot-fellows/runtimes that referenced this issue Apr 23, 2024
@Bullrich
fix review bot: updated to v2.4.1 with fix (#282)
4ad4156 
This contains the fix for paritytech/review-bot#118, which is a breaking
change introduced in V1.2.0 which causes the `Identity` object to become
a tuple.

The updated code gets the first element of the tuple.

---

Replaced the action `tibdex/github-app-token` for
`actions/create-github-app-token` which works the same way but is
developed by GitHub (which should make it more secure)

- [x] Does not require a CHANGELOG entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bullrich Bullrich

Labels
bug Something isn't working Fellows Tickets related to the fellowship
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix IdentityOf tuple introduced in v1.2.0 paritytech/review-bot
1 participant
@Bullrich