This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add new documentation guidelines (#14115)
* add new documentation style-guides * update CODEOWNERS as well * try new team * revert * Update docs/DOCUMENTATION_GUIDELINES.md Co-authored-by: Juan <juangirini@gmail.com> * Update docs/DOCUMENTATION_GUIDELINES.md Co-authored-by: Juan <juangirini@gmail.com> * Apply suggestions from code review Co-authored-by: Ben Greenberg <13892277+hummusonrails@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Sam Johnson <sam@durosoft.com> Co-authored-by: Ben Greenberg <13892277+hummusonrails@users.noreply.github.com> * Update docs/DOCUMENTATION_GUIDELINES.md * Apply suggestions from code review Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> Co-authored-by: Ben Greenberg <13892277+hummusonrails@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Ben Greenberg <13892277+hummusonrails@users.noreply.github.com> Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> * Apply suggestions from code review Co-authored-by: Sacha Lansky <sacha@parity.io> Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> * Further updates. * note about rewrap. * update ToC and more * update ToC and more * Update docs/DOCUMENTATION_GUIDELINES.md Co-authored-by: Sebastian Kunert <skunert49@gmail.com> * storage --------- Co-authored-by: Juan <juangirini@gmail.com> Co-authored-by: Ben Greenberg <13892277+hummusonrails@users.noreply.github.com> Co-authored-by: Sam Johnson <sam@durosoft.com> Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> Co-authored-by: Sacha Lansky <sacha@parity.io> Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
- Loading branch information
7 people
authored
May 26, 2023
1 parent
5b255b2
commit c470fc2
Showing
4 changed files
with
273 additions
and
13 deletions.
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,254 @@ | ||
| # Substrate Documentation Guidelines | ||
|
|
||
| This document is only focused on documenting parts of substrate that relates to its external API. The list of such crates can be found in [CODEOWNERS](./CODEOWNERS). Search for the crates that are auto-assigned to a team called `docs-audit`. | ||
|
|
||
| These are crates that are often used by external developers and need more thorough documentation. These are the crates most concerned with FRAME development. | ||
|
|
||
| - [General/Non-Pallet Crates](#generalnon-pallet-crates) | ||
| - [What to Document?](#what-to-document) | ||
| - [Rust Docs vs. Code Comments](#rust-docs-vs-code-comments) | ||
| - [How to Document?](#how-to-document) | ||
| - [TLDR](#tldr) | ||
| - [Proc-Macros](#proc-macros) | ||
| - [Other Guidelines](#other-guidelines) | ||
| - [Document Through Code](#document-through-code) | ||
| - [Formatting Matters](#formatting-matters) | ||
| - [Pallet Crates](#pallet-crates) | ||
| - [Top Level Pallet Docs (`lib.rs`)](#top-level-pallet-docs-librs) | ||
| - [Polkadot and Substrate](#polkadot-and-substrate) | ||
| - [Dispatchable](#dispatchable) | ||
| - [Storage Items](#storage-items) | ||
|
|
||
|
|
||
| ## General/Non-Pallet Crates | ||
|
|
||
| First, consider the case for all such crates, except for those that are pallets. | ||
|
|
||
| ### What to Document? | ||
|
|
||
| The first question is, what should you document? Use the following filter: | ||
|
|
||
| 1. In the crates assigned to `docs-audit` in [CODEOWNERS](./CODEOWNERS), | ||
| 2. All `pub` item need to be documented. If it is not `pub`, it does not appear in the rust-docs, and is not public facing. | ||
| * Within `pub` items, sometimes they are only `pub` in order to be used by another internal crate, and you can foresee that this will not be used by anyone else other than you. These need **not** be documented thoroughly, and are left to your discretion to identify. | ||
| * Reminder: `trait` items are public by definition, if the trait is public. | ||
| 3. All public modules (`mod`) should have reasonable module-level documentation (`//!`). | ||
|
|
||
|
|
||
| #### Rust Docs vs. Code Comments | ||
|
|
||
| Note that anything starting with `///` is an external rust-doc, and everything starting with `//` does not appear in the rust-docs. It's important to not confuse the two in your documentation. | ||
|
|
||
| ```rust | ||
| /// Computes the square root of the input, returning `Ok(_)` if successful. | ||
| /// | ||
| /// # Errors | ||
| /// ... | ||
| /// | ||
| // Details about the complexity, how you implemented this, and some quirks that | ||
| // are NOT relevant to the external interface, so it starts with '//'. | ||
| // This can also be moved inside the function. | ||
| pub fn sqrt(x: u32) -> Result<u32, ()> { | ||
| todo!(); | ||
| } | ||
| ``` | ||
|
|
||
| ### How to Document? | ||
|
|
||
| There are a few very good sources that you can look into: | ||
|
|
||
| - https://doc.rust-lang.org/rustdoc/how-to-write-documentation.html | ||
| - https://web.mit.edu/rust-lang_v1.25/arch/amd64_ubuntu1404/share/doc/rust/html/book/first-edition/documentation.html | ||
| - https://blog.guillaume-gomez.fr/articles/2020-03-12+Guide+on+how+to+write+documentation+for+a+Rust+crate | ||
|
|
||
| As mentioned [here](https://web.mit.edu/rust-lang_v1.25/arch/amd64_ubuntu1404/share/doc/rust/html/book/first-edition/documentation.html#writing-documentation-comments) and [here](https://blog.guillaume-gomez.fr/articles/2020-03-12+Guide+on+how+to+write+documentation+for+a+Rust+crate), always start with a **single sentence** demonstrating what is being documented. All additional documentation should be added *after a newline*. Strive to make the first sentence succinct and short. The reason for this is the first paragraph of docs about an item (everything before the first newline) is used as the excerpt that rust doc displays about this item when it appears in tables, such as the table listing all functions in a module. If this excerpt is too long, the module docs will be very difficult to read. | ||
|
|
||
| About [special sections](https://web.mit.edu/rust-lang_v1.25/arch/amd64_ubuntu1404/share/doc/rust/html/book/first-edition/documentation.html#special-sections), we will most likely not need to think about panic and safety in any runtime related code. Our code is never `unsafe`, and will (almost) never panic. | ||
|
|
||
| Use `# Examples as much as possible. These are great ways to further demonstrate what your APIs are doing, and add free test coverage. As an additional benefit, any code in rust-docs is treated as an "integration tests", not unit tests, which tests your crate in a different way than unit tests. So, it is both a win for "more documentation" and a win for "more test coverage". | ||
|
|
||
| You can also consider having an `# Error` section optionally. Of course, this only applies if there is a `Result` being returned, and if the `Error` variants are overly complicated. | ||
|
|
||
| Strive to include correct links to other items in your written docs as much as possible. In other words, avoid \`some_func\` and instead use \[\`some_fund\`\]. Read more about how to correctly use links in your rust-docs [here](https://doc.rust-lang.org/rustdoc/write-documentation/linking-to-items-by-name.html#valid-links) and [here](https://rust-lang.github.io/rfcs/1946-intra-rustdoc-links.html#additions-to-the-documentation-syntax). | ||
| Strive to include correct links to other items in your written docs as much as possible. In other words, avoid `` `some_func` `` and instead use ``[`some_func`]``. | ||
|
|
||
|
|
||
| > While you are linking, you might become conscious of the fact that you are in need of linking to (too many) foreign items in order to explain your API. This is leaning more towards API-Design rather than documentation, but it is a warning that the subject API might be slightly wrong. For example, most "glue" traits[^1] in `frame/support` should be designed and documented without making hard assumptions about particular pallets that implement them. | ||
| #### TLDR | ||
|
|
||
| 0. Have the goal of enforcing `#![deny(missing_docs)]` mentally, even if it is not enforced by the compiler 🙈. | ||
| 1. Start with a single, clear and concise sentence. Follow up with more context, after a newline, if needed. | ||
| 2. Use examples as much as reasonably possible. | ||
| 3. Use links as much as possible. | ||
| 4. Think about context. If you are explaining a lot of foreign topics while documenting a trait that should not explicitly depend on them, you have likely not designed it properly. | ||
|
|
||
| #### Proc-Macros | ||
|
|
||
| Note that there are special considerations when documenting proc macros. Doc links will appear to function _within_ your proc macro crate, but often will no longer function when these proc macros are re-exported elsewhere in your project. The exception is doc links to _other proc macros_ which will function just fine if they are also being re-exported. It is also often necessary to disambiguate between a proc macro and a function of the same name, which can be done using the `macro@my_macro_name` syntax in your link. Read more about how to correctly use links in your rust-docs [here](https://doc.rust-lang.org/rustdoc/write-documentation/linking-to-items-by-name.html#valid-links) and [here](https://rust-lang.github.io/rfcs/1946-intra-rustdoc-links.html#additions-to-the-documentation-syntax). | ||
|
|
||
|
|
||
| ### Other Guidelines | ||
|
|
||
| The above five guidelines must always be reasonably respected in the documentation. | ||
|
|
||
| The following are a set of notes that may not necessarily hold in all circumstances: | ||
|
|
||
|
|
||
| #### Document Through Code | ||
|
|
||
| You should make sure that your code is properly-named and well-organized so that your code functions as a form of documentation. However, within the complexity of our projects in Polkadot/Substrate that is not enough. Particularly, things like examples, errors and panics cannot be documented only through properly-named and well-organized code. | ||
|
|
||
| > Our north star is self-documenting code that also happens to be well-documented and littered with examples. | ||
|
|
||
| * Your written documents should *complement* the code, not *repeat* it. As an example, a documentation on top of a code example should never look like the following: | ||
|
|
||
| ```rust | ||
| /// Sends request and handles the response. | ||
| trait SendRequestAndHandleResponse { | ||
|
|
||
| } | ||
| ``` | ||
|
|
||
| In the above example, the documentation has added no useful information not already contained within the properly-named trait and is redundant. | ||
|
|
||
|
|
||
| #### Formatting Matters | ||
|
|
||
| The way you format your documents (newlines, heading and so on) makes a difference. Consider the below examples: | ||
|
|
||
| ```rust | ||
| /// This function works with input u32 x and multiplies it by two. If | ||
| /// we optimize the other variant of it, we would be able to achieve more | ||
| /// efficiency but I have to think about it. Probably can panic if the input | ||
| /// overflows u32. | ||
| fn multiply_by_2(x: u32) -> u32 { .. } | ||
| ``` | ||
|
|
||
| ```rust | ||
| /// Multiplies an input of type [`u32`] by two. | ||
| /// | ||
| /// # Panics | ||
| /// | ||
| /// Panics if the input overflows. | ||
| /// | ||
| /// # Complexity | ||
| /// | ||
| /// Is implemented using some algorithm that yields complexity of O(1). | ||
| // More efficiency can be achieved if we improve this via such and such. | ||
| fn multiply_by_2(x: u32) -> u32 { .. } | ||
| ``` | ||
|
|
||
| They are both roughly conveying the same set of facts, but one is easier to follow because it was formatted cleanly. Especially for traits and types that you can foresee will be seen and used a lot, try and write a well formatted version. | ||
|
|
||
| Similarly, make sure your comments are wrapped at 100 characters line-width (as defined by our [`rustfmt.toml`](../rustfmt.toml)), no **more and no less**! The more is fixed by `rustfmt` and our CI, but if you (for some unknown reason) wrap your lines at 59 characters, it will pass the CI, and it will not look good 🫣. Consider using a plugin like [rewrap](https://marketplace.visualstudio.com/items?itemName=stkb.rewrap) (for Visual Studio Code) to properly do this. | ||
|
|
||
| [^1]: Those that help two pallets talk to each other. | ||
|
|
||
| ## Pallet Crates | ||
|
|
||
| The guidelines so far have been general in nature, and are applicable to crates that are pallets and crates that're not pallets. | ||
|
|
||
| The following is relevant to how to document parts of a crate that is a pallet. See [`pallet-fast-unstake`](../frame/fast-unstake/src/lib.rs) as one examples of adhering these guidelines. | ||
|
|
||
| ### Top Level Pallet Docs (`lib.rs`) | ||
|
|
||
| For the top-level pallet docs, consider the following template: | ||
|
|
||
| ``` | ||
| //! # <Pallet Name> | ||
| //! | ||
| //! <single-liner about the pallet>. | ||
| //! | ||
| //! ## Overview | ||
| //! | ||
| //! <should be high-level details that are relevant to the most broad audience> | ||
| //! | ||
| //! <The audience here is potentially non-coders who just want to know what this pallet does, not how it does it> | ||
| //! | ||
| //! <potentially a few paragraphs, focus on what external folks should know about the pallet> | ||
| //! | ||
| //! ### Example | ||
| //! | ||
| //! <Your pallet must have a few tests that cover important user journeys. Use https://crates.io/crates/docify to reuse these as examples>. | ||
| //! | ||
| //! ## Pallet API | ||
| //! | ||
| //! <Reminder: inside the [`pallet`] module, a template that leads the reader to the relevant items is auto-generated. There is no need to repeat things like "See Config trait for ...", which are generated inside [`pallet`] here anyways. You can use the below line as-is:> | ||
| //! | ||
| //! See the [`pallet`] module for more information about the interfaces this pallet exposes, including its configuration trait, dispatchables, storage items, events and errors. | ||
| //! | ||
| //! <The audience of this is those who want to know how this pallet works, to the extent of being able to build something on top of it, like a DApp or another pallet> | ||
| //! | ||
| //! This section can most often be left as-is. | ||
| //! | ||
| //! ## Low Level / Implementation Details | ||
| //! | ||
| //! <The format of this section is up to you, but we suggest the Design-oriented approach that follows> | ||
| //! | ||
| //! <The audience of this would be your future self, or anyone who wants to gain a deep understanding of how the pallet works so that they can eventually propose optimizations to it> | ||
| //! | ||
| //! ### Design Goals (optional) | ||
| //! | ||
| //! <Describe your goals with the pallet design.> | ||
| //! | ||
| //! ### Design (optional) | ||
| //! | ||
| //! <Describe how you've reached those goals. This should describe the storage layout of your pallet and what was your approach in designing it that way.> | ||
| //! | ||
| //! ### Terminology (optional) | ||
| //! | ||
| //! <Optionally, explain any non-obvious terminology here. You can link to it if you want to use the terminology further up> | ||
| ``` | ||
|
|
||
| This template's details (heading 3s and beyond) are left flexible, and at the discretion of the developer to make the best final choice about. For example, you might want to include `### Terminology` or not. Moreover, you might find it more useful to include it in `## Overview`. | ||
|
|
||
| Nonetheless, the high level flow of going from the most high level explanation to the most low level explanation is important to follow. | ||
|
|
||
| As a rule of thumb, the Heading 2s (`##`) in this template can be considered a strict rule, while the Heading 3s (`###`) and beyond are flexible. | ||
|
|
||
| #### Polkadot and Substrate | ||
|
|
||
| Optionally, in order to demonstrate the relation between the two, you can start the pallet documentation with: | ||
|
|
||
| ``` | ||
| //! > Made with *Substrate*, for *Polkadot*. | ||
| //! | ||
| //! [![github]](https://github.com/paritytech/substrate/frame/fast-unstake) - | ||
| //! [![polkadot]](https://polkadot.network) | ||
| //! | ||
| //! [polkadot]: https://img.shields.io/badge/polkadot-E6007A?style=for-the-badge&logo=polkadot&logoColor=white | ||
| //! [github]: https://img.shields.io/badge/github-8da0cb?style=for-the-badge&labelColor=555555&logo=github | ||
| ``` | ||
|
|
||
| ### Dispatchable | ||
|
|
||
| For each dispatchable (`fn` item inside `pallet::call`), consider the following template: | ||
|
|
||
| ``` | ||
| /// <One-liner explaining what the dispatchable does> | ||
| /// | ||
| /// ## Dispatch Origin | ||
| /// | ||
| /// The dispatch origin of this call must be <details (e.g. Root, Signed, Unsigned)> | ||
| /// | ||
| /// ## Details | ||
| /// | ||
| /// <All other details, namely any errors that could occur within this dispatch and the events this dispatch could emit> | ||
| /// | ||
| /// ## Errors (optional) | ||
| /// | ||
| /// <If an extensive list of errors can be returned, list them individually instead of mentioning them in the section above> | ||
| /// | ||
| /// ## Events (optional) | ||
| /// | ||
| /// <Events are akin to the "return type" of dispatchables, optionally mention them> | ||
| pub fn name_of_dispatchable(origin: OriginFor<T>, ...) -> DispatchResult {} | ||
| ``` | ||
|
|
||
| ### Storage Items | ||
|
|
||
| 1. If a map-like type is being used, always note the choice of your hashers as private code docs (`// Hasher X chosen because ...`). Recall that this is not relevant information to external people, so it must be documented as `//`. | ||
| 2. Consider explaining the crypto-economics of how a deposit is being taken in return of the storage being used. | ||
| 3. Consider explaining why it is safe for the storage item to be unbounded, if `#[pallet::unbounded]` or `#[pallet::without_storage_info]` is being used. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters