From 8e531c3affce403712d350614b533ff4156f095d Mon Sep 17 00:00:00 2001 From: Oliver Tale-Yazdi Date: Mon, 28 Nov 2022 17:38:47 +0100 Subject: [PATCH 1/4] Typo Signed-off-by: Oliver Tale-Yazdi --- client/offchain/src/api.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/offchain/src/api.rs b/client/offchain/src/api.rs index 7d3dd8302f343..1301ce9fd9627 100644 --- a/client/offchain/src/api.rs +++ b/client/offchain/src/api.rs @@ -300,7 +300,7 @@ pub(crate) struct AsyncApi { } impl AsyncApi { - /// Creates new Offchain extensions API implementation an the asynchronous processing part. + /// Creates new Offchain extensions API implementation and the asynchronous processing part. pub fn new( network_provider: Arc, is_validator: bool, From 3fe405e5581414397e2caaf9efda49c877fe43fe Mon Sep 17 00:00:00 2001 From: Oliver Tale-Yazdi Date: Mon, 28 Nov 2022 17:13:55 +0000 Subject: [PATCH 2/4] Move rust feature check to docker and require not to fail Signed-off-by: Oliver Tale-Yazdi --- scripts/ci/gitlab/pipeline/check.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/ci/gitlab/pipeline/check.yml b/scripts/ci/gitlab/pipeline/check.yml index 878c46f32e850..3dd2cbbcc0169 100644 --- a/scripts/ci/gitlab/pipeline/check.yml +++ b/scripts/ci/gitlab/pipeline/check.yml @@ -38,9 +38,7 @@ test-dependency-rules: test-rust-features: stage: check extends: - - .kubernetes-env - .test-refs-no-trigger-prs-only - allow_failure: true script: - git clone --depth=1 From 26f523131f9cccbdf21bc4f16f724c37c5cade5e Mon Sep 17 00:00:00 2001 From: Oliver Tale-Yazdi Date: Mon, 28 Nov 2022 17:16:42 +0000 Subject: [PATCH 3/4] Add .docker-env Signed-off-by: Oliver Tale-Yazdi --- scripts/ci/gitlab/pipeline/check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/ci/gitlab/pipeline/check.yml b/scripts/ci/gitlab/pipeline/check.yml index 3dd2cbbcc0169..8cf782109b1e4 100644 --- a/scripts/ci/gitlab/pipeline/check.yml +++ b/scripts/ci/gitlab/pipeline/check.yml @@ -38,6 +38,7 @@ test-dependency-rules: test-rust-features: stage: check extends: + - .docker-env - .test-refs-no-trigger-prs-only script: - git clone From 37c54f50a850bec41786693703077b76ab23aed4 Mon Sep 17 00:00:00 2001 From: Oliver Tale-Yazdi Date: Tue, 29 Nov 2022 12:06:12 +0000 Subject: [PATCH 4/4] Move test-rust-features check back to kubernetes Signed-off-by: Oliver Tale-Yazdi --- scripts/ci/gitlab/pipeline/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ci/gitlab/pipeline/check.yml b/scripts/ci/gitlab/pipeline/check.yml index 8cf782109b1e4..55f0061501076 100644 --- a/scripts/ci/gitlab/pipeline/check.yml +++ b/scripts/ci/gitlab/pipeline/check.yml @@ -38,7 +38,7 @@ test-dependency-rules: test-rust-features: stage: check extends: - - .docker-env + - .kubernetes-env - .test-refs-no-trigger-prs-only script: - git clone