From 95695fad6edac07762352a93d9e5cc42fadd9816 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 16 Feb 2023 12:15:28 +0100 Subject: [PATCH 1/3] [ci] Add dependencies for publishsing crates --- scripts/ci/gitlab/pipeline/publish.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/scripts/ci/gitlab/pipeline/publish.yml b/scripts/ci/gitlab/pipeline/publish.yml index 3052658cde4e3..935822fa0f524 100644 --- a/scripts/ci/gitlab/pipeline/publish.yml +++ b/scripts/ci/gitlab/pipeline/publish.yml @@ -233,11 +233,19 @@ publish-draft-release: publish-crates: extends: .publish-crates-template + # publish-crates should only be run if publish-crates-locally passes + needs: + - job: publish-crates-locally + artifacts: false publish-crates-manual: extends: .publish-crates-template when: manual interruptible: false + # publish-crates should only be run if publish-crates-locally passes + needs: + - job: publish-crates-locally + artifacts: false publish-crates-locally: stage: publish From 0a3a4bff9ca06c51f203801ec433587a1971eb2c Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 16 Feb 2023 12:32:08 +0100 Subject: [PATCH 2/3] apply review comments --- scripts/ci/gitlab/pipeline/publish.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/scripts/ci/gitlab/pipeline/publish.yml b/scripts/ci/gitlab/pipeline/publish.yml index 935822fa0f524..f87f67ba4ce58 100644 --- a/scripts/ci/gitlab/pipeline/publish.yml +++ b/scripts/ci/gitlab/pipeline/publish.yml @@ -242,12 +242,8 @@ publish-crates-manual: extends: .publish-crates-template when: manual interruptible: false - # publish-crates should only be run if publish-crates-locally passes - needs: - - job: publish-crates-locally - artifacts: false -publish-crates-locally: +check-crate-publishing: stage: publish extends: - .test-refs From 2f95c15e3c0b84662edfc7fccebde961c1950ae6 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 16 Feb 2023 12:35:04 +0100 Subject: [PATCH 3/3] fix needs --- scripts/ci/gitlab/pipeline/publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ci/gitlab/pipeline/publish.yml b/scripts/ci/gitlab/pipeline/publish.yml index f87f67ba4ce58..5b06711161023 100644 --- a/scripts/ci/gitlab/pipeline/publish.yml +++ b/scripts/ci/gitlab/pipeline/publish.yml @@ -235,7 +235,7 @@ publish-crates: extends: .publish-crates-template # publish-crates should only be run if publish-crates-locally passes needs: - - job: publish-crates-locally + - job: check-crate-publishing artifacts: false publish-crates-manual: