This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Update dependencies #1527
Merged
Update dependencies #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnunicorn
added
the
A3-in_progress
gnunicorn
force-pushed
the
ben-update-deps-808
branch
from
d4b8a89 to
628337c
Compare
gnunicorn
commented
Jan 25, 2019
| let mut net = JustificationTestNet::new(3); | ||
| net.peer(0).push_blocks(20, false); | ||
| net.sync(); | ||
|
|
||
| // there's currently no justification for block #10 | ||
| assert_eq!(net.peer(0).client().justification(&BlockId::Number(10)).unwrap(), None); | ||
| assert_eq!(net.peer(1).client().justification(&BlockId::Number(10)).unwrap(), None); |
There was a problem hiding this comment.
Had an issue here and was debugging this, added the line and left it in, because it is a good check.
bkchr
approved these changes
Jan 25, 2019
gnunicorn
added
A0-please_review
bkchr
added
A8-looksgood
and removed
A0-please_review
|
As far as I can see, this is all internal dependencies and nothing we are exposing through the API. |
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* update to latest env_logger * roundabout dependency update * Update to latest vengen * Update rand to 0.6 * Update to latest rng shuffle API * Roundabout update of dependencies * Update rustc_hex * Update wasm * Fix logging setup in tests * revert to fix test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump up version to streamline our dependency tree.
refs #808