Allow 24 nominations per validator and publish count #7929

gavofyork · 2021-01-19T05:01:57Z

polkadot companion: paritytech/polkadot#2417

kianenigma

I would take such direction to prevent all runtimes being bound to this configuration:

Staking would accept type CompactSolution: sp_npos_elections::CompactSolution<T::AccountId> as input in which the max-naminations is implicitly defined.

Later on, once #7909 is merged this configuration will be moved to the new election pallet and staking would only need a type MaxNominations: Get<_>.

kianenigma · 2021-01-19T11:51:28Z

Actually, doing the above requires a bit of making things generic in staking, which is pretty much in vain if we also merge #7909. I'd say lets wait until we are almost at the next release:

if 7909 is merged, there's no need for this.
else, we merge this one.

I'll get it in good shape anyhow though.

kianenigma · 2021-01-21T15:18:18Z

Should build well now and the 24 is configurable from the runtime. Lots of boilerplate. as you see, so I'd consider not doing it this way as this will all be removed by the linked PR anyhow.

kianenigma · 2021-01-21T15:22:08Z

frame/staking/src/lib.rs

 };
 pub use weights::WeightInfo;

+/// The default solution type used in substrate-node with 24 maximum winners. A runtime can customize this to their needs.
+pub mod default_solution {


Honestly I put this mostly here so that it can be blindly used in tests/benchmarks etc. Polkadot or any other chain should probably generate their own version.

kianenigma · 2021-01-21T15:22:35Z

frame/staking/src/lib.rs

+	/// The compact solution type used to accept offchain solution.
+	///
+	/// This is implicitly encoding the maximum number of nominations as well.
+	type CompactSolution: CompactSolution + frame_support::Parameter + Default;


TLDR ^^^^^^^^^^^^^^^^^

kianenigma · 2021-02-08T16:52:00Z

frame/offences/benchmarking/src/lib.rs

@@ -208,7 +209,7 @@ benchmarks! {
 		let r in 1 .. MAX_REPORTERS;
 		// we skip 1 offender, because in such case there is no slashing
 		let o in 2 .. MAX_OFFENDERS;
-		let n in 0 .. MAX_NOMINATORS.min(MAX_NOMINATIONS as u32);
+		let n in 0 .. MAX_NOMINATORS.min(<T as pallet_staking::Config>::CompactSolution::LIMIT as u32);


I kinda blindly changed these and didn't check the full scope, they were 16 before, and now they are 24, just different syntax.

we can reexecute benchmarks to see

gavofyork · 2021-02-08T20:52:39Z

companion failing @kianenigma

gui1117

the title of the PR should be "Allow 24 nominations per nominator and publish count", no ?

frame/staking/src/lib.rs

gui1117

staking weight should be updated also I think,

otherwise looks good to me

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

…nominations

…into gav-24-nominations

kianenigma · 2021-02-10T17:05:16Z

Has a companion now, locally my build was borked but had something to do with tracing in network crate, so def. not my issue. All runtimes build go well.

Will wait to see the result here.

Either way, it is ready for audit.

…nominations

gnunicorn · 2021-03-04T08:58:05Z

anyone working on this?

kianenigma · 2021-03-04T10:54:12Z

awaiting audit as it is no longer trivial.

kianenigma · 2021-03-16T09:44:48Z

reintroduced in #8113

Allow 24 nominations per validator and publish count

ca69a9b

gavofyork requested a review from kianenigma January 19, 2021 05:01

github-actions bot added the A0-please_review Pull request needs code review. label Jan 19, 2021

gavofyork added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. labels Jan 19, 2021

paritytech-ci added the D2-breaksapi label Jan 19, 2021

kianenigma reviewed Jan 19, 2021

View reviewed changes

kianenigma mentioned this pull request Jan 19, 2021

Attempt to remove the where bounds in arithmetic. #7933

Merged

Fix test.

1d2a95f

github-actions bot added the A7-needspolkadotpr label Jan 19, 2021

kianenigma added 6 commits January 19, 2021 19:24

Fix fuzzers.

75d65d3

Another fix.

0975077

checkpoint

8409407

checkpoint

c5b2836

Again, merge master

3730a32

Tidy it up.

7d53b07

gavofyork requested a review from andresilva as a code owner January 21, 2021 15:15

kianenigma reviewed Jan 21, 2021

View reviewed changes

remove cfg

a128b7a

kianenigma reviewed Feb 8, 2021

View reviewed changes

gui1117 reviewed Feb 9, 2021

View reviewed changes

frame/staking/src/lib.rs Outdated Show resolved Hide resolved

gui1117 reviewed Feb 9, 2021

View reviewed changes

frame/staking/src/lib.rs Outdated Show resolved Hide resolved

frame/staking/src/lib.rs Outdated Show resolved Hide resolved

gui1117 approved these changes Feb 9, 2021

View reviewed changes

kianenigma and others added 5 commits February 9, 2021 17:49

Update frame/staking/src/lib.rs

ca0e5ad

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

Update frame/staking/src/lib.rs

1eccbae

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

Update frame/staking/src/lib.rs

ec3ad08

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

Merge branch 'master' of github.com:paritytech/substrate into gav-24-…

69eb563

…nominations

Merge branch 'gav-24-nominations' of github.com:paritytech/substrate …

45e9c65

…into gav-24-nominations

kianenigma mentioned this pull request Feb 10, 2021

companion for substrate/pull/7929 (24 nominators) paritytech/polkadot#2417

Closed

make the line width happy.

57cdfe5

kianenigma added the D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited label Feb 10, 2021

kianenigma added 2 commits February 10, 2021 17:09

Line width, again.

32f2c7f

Merge branch 'master' of github.com:paritytech/substrate into gav-24-…

0e32536

…nominations

jacogr mentioned this pull request Feb 27, 2021

Adjust solution types for 24 nominators polkadot-js/api#3233

Closed

gnunicorn added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Mar 4, 2021

kianenigma mentioned this pull request Mar 16, 2021

Make the number of nominations configurable #8368

Merged

kianenigma closed this Mar 16, 2021

shawntabrizi removed the D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited label Feb 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow 24 nominations per validator and publish count #7929

Allow 24 nominations per validator and publish count #7929

gavofyork commented Jan 19, 2021 •

edited by kianenigma

Loading

kianenigma left a comment

kianenigma commented Jan 19, 2021

kianenigma commented Jan 21, 2021

kianenigma Jan 21, 2021

kianenigma Jan 21, 2021

kianenigma Feb 8, 2021

gui1117 Feb 9, 2021

gavofyork commented Feb 8, 2021

gui1117 left a comment •

edited

Loading

gui1117 left a comment

kianenigma commented Feb 10, 2021 •

edited

Loading

gnunicorn commented Mar 4, 2021

kianenigma commented Mar 4, 2021

kianenigma commented Mar 16, 2021 •

edited

Loading

Allow 24 nominations per validator and publish count #7929

Allow 24 nominations per validator and publish count #7929

Conversation

gavofyork commented Jan 19, 2021 • edited by kianenigma Loading

kianenigma left a comment

Choose a reason for hiding this comment

kianenigma commented Jan 19, 2021

kianenigma commented Jan 21, 2021

kianenigma Jan 21, 2021

Choose a reason for hiding this comment

kianenigma Jan 21, 2021

Choose a reason for hiding this comment

kianenigma Feb 8, 2021

Choose a reason for hiding this comment

gui1117 Feb 9, 2021

Choose a reason for hiding this comment

gavofyork commented Feb 8, 2021

gui1117 left a comment • edited Loading

Choose a reason for hiding this comment

gui1117 left a comment

Choose a reason for hiding this comment

kianenigma commented Feb 10, 2021 • edited Loading

gnunicorn commented Mar 4, 2021

kianenigma commented Mar 4, 2021

kianenigma commented Mar 16, 2021 • edited Loading

gavofyork commented Jan 19, 2021 •

edited by kianenigma

Loading

gui1117 left a comment •

edited

Loading

kianenigma commented Feb 10, 2021 •

edited

Loading

kianenigma commented Mar 16, 2021 •

edited

Loading