try-runtime-cli: Add execute-block subcommand #9077

emostov · 2021-06-11T00:48:21Z

This PR adds the execute-block subcomand to the try-runtime command. execute-block allows the user to specify a block to execute against the runtime state of its parent block.

Update 1: this removes the --header-at option, and now conditionally has --block-at as a shared option; thus --block-at is no longer an options for live.

Update 2: --url is now a shared param and is no longer used as arg to the state subcommand.

NOTE: for anyone trying out this tool you may need to bump the --max-rpc-payload on the archive node used for live queries in order to load in some bigger storage items

coriolinus

Looks generally good, with some nits. Ping me again when CI is green?

utils/frame/remote-externalities/src/rpc_api.rs

utils/frame/try-runtime/cli/src/lib.rs

emostov · 2021-06-14T20:52:02Z

~~Noting that will likely want to always overwrite code for offchain-worker, but I need to double check this cc @kianenigma~~

utils/frame/try-runtime/cli/src/lib.rs

coriolinus

Listed a few minor potential improvements above, but they all can be considered optional; none of them are real blockers.

…ubstrate into zeke-try-runtime-exec-block

emostov · 2021-06-17T19:03:32Z

utils/frame/try-runtime/cli/src/lib.rs

+			builder.inject_key_value(&[(code_key, code)]).build().await?
+		} else {
+			builder
+				.inject_hashed_key(well_known_keys::CODE)


this is fine, but i don't 100% understand the case when you would not fetch state from the all the runtime modules?

@kianenigma, perhaps obvious I also think its worth noting that this will have no affect on the builder if we are using State::Snap

this is fine, but i don't 100% understand the case when you would not fetch state from the all the runtime modules?

For example of the offchain worker, you are only interested in executing the OCW of one pallet. Albeit, you must be sure that the OCW of all other pallets won't panic or sth if they don't have any data set in their pallet.

@kianenigma but does execute block run the offchain worker? my point here is that i don't see why you would run execute_block without downloading the whole state because otherwise you get a storage root mismatch

however maybe some edgecase i don't know about

emostov

@kianenigma your changes look good to me

Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

…tytech/substrate into zeke-try-runtime-exec-block

* add helper for block_at * remove redundant bound * doc for fn block_at

…tytech/substrate into zeke-try-runtime-exec-block

kianenigma

LGMT

emostov · 2021-06-22T20:36:06Z

bot merge

ghost · 2021-06-22T20:36:11Z

Trying merge.

* Refactor remote_externalities::rpc_api * try-runtime-cli: Adde `execute-block` subcommand * Trivial * Address some comments * Use required_if & remove header-at usage * Improve doc * Update comment * small tweaks * add overwrite-code to shared params * Update utils/frame/try-runtime/cli/src/lib.rs Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * make url a shared param * add helper for block_at (#9153) * add helper for block_at * remove redundant bound * doc for fn block_at * Update error message Co-authored-by: kianenigma <kian@parity.io> Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

emostov added 2 commits June 9, 2021 16:48

Refactor remote_externalities::rpc_api

9683eb2

try-runtime-cli: Adde execute-block subcommand

22b96f9

github-actions bot added the A0-please_review Pull request needs code review. label Jun 11, 2021

Trivial

4f38071

emostov requested a review from coriolinus June 11, 2021 00:54

emostov added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jun 11, 2021

Merge remote-tracking branch 'origin' into zeke-try-runtime-exec-block

3df913b

emostov removed the request for review from coriolinus June 11, 2021 04:05

emostov marked this pull request as draft June 11, 2021 04:06

emostov marked this pull request as ready for review June 11, 2021 23:46

emostov requested review from coriolinus and bkchr June 11, 2021 23:46

coriolinus reviewed Jun 14, 2021

View reviewed changes

emostov added 5 commits June 15, 2021 12:08

Address some comments

ba0e5a6

Use required_if & remove header-at usage

bada167

Merge remote-tracking branch 'origin' into zeke-try-runtime-exec-block

7b2afd3

Improve doc

36f2043

Update comment

742e9a5

emostov requested a review from coriolinus June 16, 2021 23:09

coriolinus reviewed Jun 17, 2021

View reviewed changes

utils/frame/try-runtime/cli/src/lib.rs Outdated Show resolved Hide resolved

coriolinus reviewed Jun 17, 2021

View reviewed changes

utils/frame/try-runtime/cli/src/lib.rs Outdated Show resolved Hide resolved

coriolinus reviewed Jun 17, 2021

View reviewed changes

utils/frame/try-runtime/cli/src/lib.rs Outdated Show resolved Hide resolved

coriolinus reviewed Jun 17, 2021

View reviewed changes

utils/frame/try-runtime/cli/src/lib.rs Outdated Show resolved Hide resolved

coriolinus approved these changes Jun 17, 2021

View reviewed changes

emostov and others added 3 commits June 17, 2021 10:27

Merge remote-tracking branch 'origin' into zeke-try-runtime-exec-block

864c045

small tweaks

354d88e

Merge branch 'zeke-try-runtime-exec-block' of github.com:paritytech/s…

2d2ee68

…ubstrate into zeke-try-runtime-exec-block

emostov commented Jun 17, 2021

View reviewed changes

emostov and others added 4 commits June 17, 2021 12:35

add overwrite-code to shared params

033dfbc

Update utils/frame/try-runtime/cli/src/lib.rs

282ace2

Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

make url a shared param

59c189c

Merge branch 'zeke-try-runtime-exec-block' of https://github.com/pari…

7c2e351

…tytech/substrate into zeke-try-runtime-exec-block

emostov requested review from gui1117 and kianenigma June 18, 2021 19:01

coriolinus mentioned this pull request Jun 21, 2021

add helper for block_at #9153

Merged

coriolinus and others added 4 commits June 21, 2021 10:11

add helper for block_at (#9153)

db29fec

* add helper for block_at * remove redundant bound * doc for fn block_at

Update error message

2a8d777

Merge branch 'zeke-try-runtime-exec-block' of https://github.com/pari…

ccdc601

…tytech/substrate into zeke-try-runtime-exec-block

Merge remote-tracking branch 'origin' into zeke-try-runtime-exec-block

ef1d0af

emostov added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Jun 22, 2021

kianenigma approved these changes Jun 22, 2021

View reviewed changes

shawntabrizi approved these changes Jun 22, 2021

View reviewed changes

ghost merged commit 6242d37 into master Jun 22, 2021

ghost deleted the zeke-try-runtime-exec-block branch June 22, 2021 20:36

zjb0807 mentioned this pull request Jun 23, 2021

Offchain worker try-runtime integration AcalaNetwork/Acala#1080

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

try-runtime-cli: Add execute-block subcommand #9077

try-runtime-cli: Add execute-block subcommand #9077

emostov commented Jun 11, 2021 •

edited

Loading

coriolinus left a comment

emostov commented Jun 14, 2021 •

edited

Loading

coriolinus left a comment

emostov Jun 17, 2021

emostov Jun 18, 2021

kianenigma Jun 22, 2021

emostov Jun 22, 2021 •

edited

Loading

emostov left a comment

kianenigma left a comment

emostov commented Jun 22, 2021

ghost commented Jun 22, 2021

try-runtime-cli: Add execute-block subcommand #9077

try-runtime-cli: Add execute-block subcommand #9077

Conversation

emostov commented Jun 11, 2021 • edited Loading

coriolinus left a comment

Choose a reason for hiding this comment

emostov commented Jun 14, 2021 • edited Loading

coriolinus left a comment

Choose a reason for hiding this comment

emostov Jun 17, 2021

Choose a reason for hiding this comment

emostov Jun 18, 2021

Choose a reason for hiding this comment

kianenigma Jun 22, 2021

Choose a reason for hiding this comment

emostov Jun 22, 2021 • edited Loading

Choose a reason for hiding this comment

emostov left a comment

Choose a reason for hiding this comment

kianenigma left a comment

Choose a reason for hiding this comment

emostov commented Jun 22, 2021

ghost commented Jun 22, 2021

emostov commented Jun 11, 2021 •

edited

Loading

emostov commented Jun 14, 2021 •

edited

Loading

emostov Jun 22, 2021 •

edited

Loading