Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix: CARGO_TARGET_DIR_freeze #9114

Merged
1 commit merged into from
Jun 15, 2021
Merged

fix: CARGO_TARGET_DIR_freeze #9114

1 commit merged into from
Jun 15, 2021

Conversation

eopb
Copy link
Contributor

@eopb eopb commented Jun 15, 2021

Fixes #9113

See #9113 for details on what issue this PR attempts to solve.

This is my first PR on this project 😅 so any reviews pointing out anything I may have got wrong would be greatly appreciated.

@eopb
Copy link
Contributor Author

eopb commented Jun 15, 2021

User @eopb, please sign the CLA here.

That link is to a localhost address 🤔 http://127.0.0.1:3001/sign_cla/8074468/3. Is that intentional? How am I supposed to sign it?

@joao-paulo-parity
Copy link
Contributor

sorry @eopb, please try http://cla.parity.io/sign_cla/8074468/3

@paritytech paritytech deleted a comment from cla-bot-2021 bot Jun 15, 2021
bkchr
bkchr suggested changes Jun 15, 2021
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just do it, as it is done here https://github.com/paritytech/substrate/blob/master/utils/wasm-builder/src/wasm_project.rs#L424

@eopb eopb force-pushed the CARGO_TARGET_DIR_freeze branch from 3a31df8 to 419af81 Compare June 15, 2021 14:51
@eopb
Copy link
Contributor Author

eopb commented Jun 15, 2021

sorry @eopb, please try http://cla.parity.io/sign_cla/8074468/3

I've signed the CLA but as far as I can tell the bot does not seem to have noticed

@joao-paulo-parity
Copy link
Contributor

/cla run-cla-check

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Jun 15, 2021

Queueing command execution: run-cla-check

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Jun 15, 2021

@joao-paulo-parity Command execution has finished.

@eopb eopb requested a review from bkchr June 15, 2021 14:56
@joao-paulo-parity
Copy link
Contributor

@eopb Thanks for signing. Feedback is welcome if it was difficult or confusing. Sorry for any inconvenience!

@TriplEight TriplEight requested review from TriplEight and a team and removed request for TriplEight June 15, 2021 15:45
TriplEight
TriplEight approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, this was indeed an issue for wasm build.

@bkchr
Copy link
Member

bkchr commented Jun 15, 2021

bot merge

@ghost
Copy link

ghost commented Jun 15, 2021

Waiting for commit status.

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 15, 2021
@ghost ghost merged commit 7f09a76 into paritytech:master Jun 15, 2021
@eopb eopb deleted the CARGO_TARGET_DIR_freeze branch June 16, 2021 09:45
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TriplEight TriplEight TriplEight approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enviroments with CARGO_TARGET_DIR set cause builds using wasm-builder to freeze
4 participants
@eopb @joao-paulo-parity @bkchr @TriplEight